Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Asyncify option to propagate the addList #5935

Merged
merged 9 commits into from
Apr 1, 2024

Conversation

nokotan
Copy link
Contributor

@nokotan nokotan commented Sep 13, 2023

This PR will take #3794 over.

New asyncify flag --pass-arg=asyncify-propagate-addlist will change --pass-arg=asyncify-addlist behavior, callers of functions in a asyncify-addlist will be also instrumented.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #5935 (edd4170) into main (e9d0fb7) will increase coverage by 0.44%.
Report is 41 commits behind head on main.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main    #5935      +/-   ##
==========================================
+ Coverage   42.60%   43.05%   +0.44%     
==========================================
  Files         484      492       +8     
  Lines       74837    74968     +131     
  Branches    11922    11683     -239     
==========================================
+ Hits        31887    32279     +392     
+ Misses      39750    39457     -293     
- Partials     3200     3232      +32     
Files Coverage Δ
src/passes/Asyncify.cpp 87.59% <76.47%> (+0.01%) ⬆️

... and 65 files with indirect coverage changes

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here! I think I missed a notification here or something. This looks great.

@kripken kripken merged commit 4433454 into WebAssembly:main Apr 1, 2024
14 checks passed
kripken added a commit that referenced this pull request Apr 2, 2024
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants