Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec/interpreter/test] Spec & implement proposal #4

Merged
merged 6 commits into from
May 13, 2019
Merged

[spec/interpreter/test] Spec & implement proposal #4

merged 6 commits into from
May 13, 2019

Conversation

rossberg
Copy link
Member

This should include everything necessary for stage 3:

  • Specify syntax of annotations.
  • Implement annotation parsing in interpreter.
  • Test for annotation parsing.
  • Bonus: specify @name and @Custom annotations in spec appendix.

Like with the custom sections, the interpreter only implements generic parsing of annotation syntax and otherwise ignores it.

@rossberg
Copy link
Member Author

@lukewagner, friendly ping.

lukewagner
lukewagner approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@lukewagner lukewagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I missed this review request. lgtm

@rossberg rossberg merged commit 1a33be6 into master May 13, 2019
@rossberg rossberg deleted the all branch May 13, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewagner lukewagner lukewagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossberg @lukewagner