-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in initialize function. #93
Conversation
grvgoel81
commented
Jul 5, 2024
- Returns CompletableFuture after both success and error.
Signed-off-by: Gaurav Goel <[email protected]>
Signed-off-by: Gaurav Goel <[email protected]>
Signed-off-by: Gaurav Goel <[email protected]>
Signed-off-by: Gaurav Goel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -182,10 +182,10 @@ class Web3Auth(web3AuthOptions: Web3AuthOptions) { | |||
this.authorizeSession().whenComplete { resp, error -> | |||
if (error == null) { | |||
web3AuthResponse = resp | |||
initializeCf.complete(null) | |||
} else { | |||
print(error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just informational.
Instead of print(error)
you could do this:
Log.e(tag, error);
Then you can use logcat with adb.