-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure almost the whole community portal and add content to some pages #21
base: master
Are you sure you want to change the base?
Conversation
Part 2 should include the remaining pages of the sitemap: https://github.com/WeAreFairphone/community-portal/wiki/Proposed-portal-hierarchy
The remaining pages are still lacking content and should be populated in the future (part 2, etc.).
The events.md can be used as a template for the remaining pages, where the subpages are not implemented yet.
Hi, thanks for your contribution. I checked it out to run it locally like so: $ git remote add stefanbrand https://github.com/StefanBrand/community-portal.git
$ git fetch stefanbrand
remote: Counting objects: 67, done.
remote: Compressing objects: 100% (43/43), done.
remote: Total 67 (delta 25), reused 66 (delta 24), pack-reused 0
Entpacke Objekte: 100% (67/67), Fertig.
Von https://github.com/StefanBrand/community-portal
* [neuer Branch] master -> stefanbrand/master
$ git checkout stefanbrand/master
Hinweis: Checke 'stefanbrand/master' aus.
Sie befinden sich im Zustand eines 'losgelösten HEAD'. Sie können sich
umschauen, experimentelle Änderungen vornehmen und diese committen, und
Sie können alle möglichen Commits, die Sie in diesem Zustand machen,
ohne Auswirkungen auf irgendeinen Branch verwerfen, indem Sie einen
weiteren Checkout durchführen.
Wenn Sie einen neuen Branch erstellen möchten, um Ihre erstellten Commits
zu behalten, können Sie das (jetzt oder später) durch einen weiteren Checkout
mit der Option -b tun. Beispiel:
git checkout -b <neuer-Branchname>
HEAD ist jetzt bei 1936e59... Add a list (similar to home) to pages that have subpages (part1)
$ git status
HEAD losgelöst bei stefanbrand/master
nichts zu committen, Arbeitsverzeichnis unverändert When running a local instance I see some missing translations:
Plus, the navigation with subpages seem to be broken (I expected some hashes in http://localhost:4000/pages/events.html to indicate a subpage. Alternatively a new URL.) Could you update the Sitemap (http://localhost:4000/sitemap.html) too? Don't mind about translation files not being displayed. I'm investigating that one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment.
Some commits describe work that has only partly been completed (for one thing I was getting tired, then again it was also a proof-of-concept): 2102d49 2aa2e9e & 1936e59