Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure almost the whole community portal and add content to some pages #21

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

StefanBrand
Copy link
Contributor

@StefanBrand StefanBrand commented Jan 3, 2018

Some commits describe work that has only partly been completed (for one thing I was getting tired, then again it was also a proof-of-concept): 2102d49 2aa2e9e & 1936e59

@Ryuno-Ki
Copy link
Collaborator

Ryuno-Ki commented Jan 4, 2018

Hi,

thanks for your contribution.

I checked it out to run it locally like so:

$ git remote add stefanbrand https://github.com/StefanBrand/community-portal.git
$ git fetch stefanbrand 
remote: Counting objects: 67, done.
remote: Compressing objects: 100% (43/43), done.
remote: Total 67 (delta 25), reused 66 (delta 24), pack-reused 0
Entpacke Objekte: 100% (67/67), Fertig.
Von https://github.com/StefanBrand/community-portal
 * [neuer Branch]    master     -> stefanbrand/master
$ git checkout stefanbrand/master 
Hinweis: Checke 'stefanbrand/master' aus.

Sie befinden sich im Zustand eines 'losgelösten HEAD'. Sie können sich
umschauen, experimentelle Änderungen vornehmen und diese committen, und
Sie können alle möglichen Commits, die Sie in diesem Zustand machen,
ohne Auswirkungen auf irgendeinen Branch verwerfen, indem Sie einen
weiteren Checkout durchführen.

Wenn Sie einen neuen Branch erstellen möchten, um Ihre erstellten Commits
zu behalten, können Sie das (jetzt oder später) durch einen weiteren Checkout
mit der Option -b tun. Beispiel:

  git checkout -b <neuer-Branchname>

HEAD ist jetzt bei 1936e59... Add a list (similar to home) to pages that have subpages (part1)
$ git status
HEAD losgelöst bei stefanbrand/master
nichts zu committen, Arbeitsverzeichnis unverändert

When running a local instance I see some missing translations:

$ bundle exec jekyll serve
Configuration file: $PROJECTROOT/_config.yml
            Source: $PROJECTROOT
       Destination: $PROJECTROOT/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
Building site for default language: "en" to: $PROJECTROOT/_site
Loading translation from file $PROJECTROOT/_i18n/en.yml
Missing i18n key: en:subpage.title
Using translation '' from default language: en
Missing i18n key: en:subpage.title
Using translation '' from default language: en
Missing i18n key: en:subpage.title
Using translation '' from default language: en
Missing i18n key: en:subpage.title
Using translation '' from default language: en
Missing i18n key: en:subpage.title
Using translation '' from default language: en
Missing i18n key: en:subpage.title
Using translation '' from default language: en
Missing i18n key: en:subpage.title
Using translation '' from default language: en
Building site for language: "de" to: $PROJECTROOT/_site/de
Loading translation from file $PROJECTROOT/_i18n/de.yml
Missing i18n key: de:subpage.title
Using translation '' from default language: en
Missing i18n key: de:pages.apks.title
Using translation 'Community Apps' from default language: en
Missing i18n key: de:pages.contribute.title
Using translation 'Contribute' from default language: en
Missing i18n key: de:pages.contribute.title
Using translation 'Contribute' from default language: en
Missing i18n key: de:subpage.title
Using translation '' from default language: en
Missing i18n key: de:pages.custom-roms.title
Using translation 'Custom Roms' from default language: en
Missing i18n key: de:pages.design.title
Using translation 'Design Guidelines' from default language: en
Missing i18n key: de:pages.design.title
Using translation 'Design Guidelines' from default language: en
Missing i18n key: de:subpage.title
Using translation '' from default language: en
Missing i18n key: de:pages.efct.title
Using translation 'European Fairphoners Community Meetup' from default language: en
Missing i18n key: de:subpage.title
Using translation '' from default language: en
Missing i18n key: de:pages.event-guide.title
Using translation 'Fairphone Meetup Guide' from default language: en
Missing i18n key: de:subpage.title
Using translation '' from default language: en
Missing i18n key: de:pages.events.title
Using translation 'Community Events' from default language: en
Missing i18n key: de:pages.efct.title
Using translation 'European Fairphoners Community Meetup' from default language: en
Missing i18n key: de:pages.event-guide.title
Using translation 'Fairphone Meetup Guide' from default language: en
Missing i18n key: de:pages.local-events.title
Using translation 'Local Meetups and Events' from default language: en
Missing i18n key: de:pages.events.title
Using translation 'Community Events' from default language: en
Missing i18n key: de:subpage.title
Using translation '' from default language: en
Missing i18n key: de:pages.flashable-zips.title
Using translation 'Flashable ZIPs' from default language: en
Missing i18n key: de:pages.hardware.title
Using translation 'DIY & Repair' from default language: en
Missing i18n key: de:pages.hardware.title
Using translation 'DIY & Repair' from default language: en
Missing i18n key: de:pages.contribute.title
Using translation 'Contribute' from default language: en
Missing i18n key: de:pages.design.title
Using translation 'Design Guidelines' from default language: en
Missing i18n key: de:pages.events.title
Using translation 'Community Events' from default language: en
Missing i18n key: de:pages.hardware.title
Using translation 'DIY & Repair' from default language: en
Missing i18n key: de:pages.online.title
Using translation 'Online Communities' from default language: en
Missing i18n key: de:pages.software.title
Using translation 'Custom Roms & other Software' from default language: en
Missing i18n key: de:subpage.title
Using translation '' from default language: en
Missing i18n key: de:pages.local-events.title
Using translation 'Local Meetups and Events' from default language: en
Missing i18n key: de:pages.online.title
Using translation 'Online Communities' from default language: en
Missing i18n key: de:pages.online.title
Using translation 'Online Communities' from default language: en
Missing i18n key: de:pages.software.title
Using translation 'Custom Roms & other Software' from default language: en
Missing i18n key: de:pages.software.title
Using translation 'Custom Roms & other Software' from default language: en
Build complete
                    done in 92.94 seconds.
 Auto-regeneration: enabled for '$PROJECTROOT'
    Server address: http://127.0.0.1:4000/
  Server running... press ctrl-c to stop.

Plus, the navigation with subpages seem to be broken (I expected some hashes in http://localhost:4000/pages/events.html to indicate a subpage. Alternatively a new URL.)

Could you update the Sitemap (http://localhost:4000/sitemap.html) too?

Don't mind about translation files not being displayed. I'm investigating that one.

Copy link
Collaborator

@Ryuno-Ki Ryuno-Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants