Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment that says wf-dock started with autostart_wf_shell #2329

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

tyressk
Copy link
Contributor

@tyressk tyressk commented Apr 11, 2024

Quick PR to remove comment from waybar.ini that says wf-dock is started by autostart_wf_shell (issue)

Fixes #2327

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can nonetheless leave a comment about wf-dock (otherwise I guess most people won't even notice its existence if they are looking for a basic dock)? But explicitly saying that it's not enabled by default.

@tyressk
Copy link
Contributor Author

tyressk commented Apr 11, 2024

@ammen99 I think that's a good idea. I added a comment in

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks!

@ammen99 ammen99 merged commit d675db6 into WayfireWM:master Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wf-dock doesn't start with autostart_wf_shell (wayconfig.ini comments confirms it should)
2 participants