Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy config.h approach from wlroots-full.hpp to other public api headers #2225

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Copy config.h approach from wlroots-full.hpp to other public api headers #2225

merged 1 commit into from
Mar 18, 2024

Conversation

parona-source
Copy link
Contributor

  • Otherwise wayfire could use the config.h of an already installed wayfire installation and lead to confusing linking issues if the options differed (like installed wayfire has xwayland disabled and the new build has it enabled).

ammen99
ammen99 reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is indeed a good catch! Could you also fix debug.hpp to use the same (WF_USE_CONFIG_H instead of the other macro)?

@parona-source
Copy config.h approach from wlroots-full.hpp to other public api headers
c00979b 
* Otherwise wayfire could use the config.h of an already installed
  wayfire installation and lead to confusing linking issues if the
  options differed (like installed wayfire has xwayland disabled and the
  new build has it enabled).

Signed-off-by: Alfred Wingate <[email protected]>
@parona-source
Copy link
Contributor Author

Pushed, didnt notice debug.hpp as my grep was too naive for that.

ammen99
ammen99 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ammen99 ammen99 merged commit f7bcad1 into WayfireWM:master Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parona-source @ammen99