Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add views to signals #2196

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

marcusbritanicus
Copy link
Contributor

Add wayfire_toplevel_view arg to two signals:

  • view_activated_state_signal
  • view_parent_changed_signal

- view_activated_state_signal
- view_parent_changed_signal
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we ought to bump the API/ABI version in plugin.hpp. Otherwise LGTM.

@marcusbritanicus
Copy link
Contributor Author

Ah!! I knew I had missed something... :) Give me a few minutes.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@ammen99 ammen99 merged commit 3c7f3e1 into WayfireWM:master Mar 11, 2024
4 checks passed
ammen99 pushed a commit that referenced this pull request Mar 13, 2024
* Add wayfire_toplevel_view arg to two signals:

- view_activated_state_signal
- view_parent_changed_signal

* Restore gtk-shell.cpp

* Bump API/ABI version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants