Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipc-rules: Add get-view-pid to get the active view pid #2131

Merged
merged 3 commits into from
Feb 11, 2024

Conversation

soreau
Copy link
Member

@soreau soreau commented Feb 10, 2024

No description provided.

@killown
Copy link
Contributor

killown commented Feb 10, 2024

could we have the pid info in "window-rules/get-focused-view" instead ?

so for example we could do things like [i["pid"] for i in list_view()] to get pid from all views

@ammen99
Copy link
Member

ammen99 commented Feb 10, 2024

I think we don't need an additional method we should report this as a property of the view in the other methods like get-focused-view, list-views etc

@soreau soreau force-pushed the ipc-get-view-pid branch 4 times, most recently from 4f721c4 to d2733dd Compare February 10, 2024 16:56
@soreau soreau force-pushed the ipc-get-view-pid branch 2 times, most recently from 8d51819 to 5816ec2 Compare February 10, 2024 17:07
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'll fix the tests and merge once I verify that everything works correctly :)

@ammen99 ammen99 merged commit 638a979 into master Feb 11, 2024
8 checks passed
@ammen99 ammen99 deleted the ipc-get-view-pid branch February 11, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants