Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some input method fixes (take 2) #2113

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Some input method fixes (take 2) #2113

merged 7 commits into from
Feb 27, 2024

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    f1c06b6 View commit details
    Browse the repository at this point in the history
  2. input method: move im key processing up to on_key and don't ignore su…

    …perfluous release events
    
    These events may be sent by the IM, and meant to reach the client.
    
    check:
    
    * in firefox, no text input, press ctrl-l, there should not be
      continuous l being inserted into the urlbar
    * in firefox, with text input, press super+some key to switch workspace
      and back (but don't release super inbetween). click in firefox, super
      should not be consider pressed
    * with text input, does the switcher plugin activate and deactivate correctly
    lilydjwg committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    984e175 View commit details
    Browse the repository at this point in the history
  3. input method: avoid sending IM sent keys to grabs.

    IM sends release key events when deactivated, which caused e.g. the
    switcher plugin to deactivate early. The plugin has a higher priority
    when activating, but lower for subsequent key events.
    lilydjwg committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5452f16 View commit details
    Browse the repository at this point in the history
  4. input method: remove focus change workaround

    fcitx5 no longer commit_string on deactivating.
    lilydjwg committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5b7afe3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6bd1179 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. don't wlr_seat_set_keyboard if keys are going to the input method.

    Or we'll alternate between two keyboards, sending a lot of keymap and
    repeat_info events to all clients.
    lilydjwg committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8f1e954 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Configuration menu
    Copy the full SHA
    7c1301e View commit details
    Browse the repository at this point in the history