Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for wlr_drm_lease_v1 #2083

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Conversation

CharlieQLe
Copy link
Contributor

First time with C++ and wlroots, so not sure if everything here is exactly proper C++. This is based off of how swaywm handles DRM leasing. I'm running on Fedora Silverblue via my own image based off of Universal Blue, and I used SteamVR in an Arch Linux container via Distrobox. It seems to work fine with my HTC Vive, but I've only tested this for a few minutes. It should work fine with other native VR headsets, but I don't have any to test. It should also work fine with other VR runtimes such as Monado, but I haven't figured out how to set that up yet.

Fixes #1581

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any possibility to test this so I'll trust you that it works :)

There are a few small issues to be fixed, otherwise LGTM, we can merge.

src/core/output-layout.cpp Outdated Show resolved Hide resolved
src/core/core.cpp Outdated Show resolved Hide resolved
src/core/core.cpp Outdated Show resolved Hide resolved
@CharlieQLe
Copy link
Contributor Author

I don't have any possibility to test this so I'll trust you that it works :)

There are a few small issues to be fixed, otherwise LGTM, we can merge.

Should be good now!

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ammen99
Copy link
Member

ammen99 commented Dec 29, 2023

The code style still isnt perfect, take a look at the CI logs, there is a diff you can apply to fix it ...

@CharlieQLe
Copy link
Contributor Author

The code style still isnt perfect, take a look at the CI logs, there is a diff you can apply to fix it ...

Running uncrustify as in the contributing doc shows changes in animate, particle, and blur-base, all of which have nothing to do with this PR. Would you still like me to push changes for those files?

@ammen99
Copy link
Member

ammen99 commented Dec 29, 2023

Running uncrustify as in the contributing doc shows changes in animate, particle, and blur-base, all of which have nothing to do with this PR. Would you still like me to push changes for those files?

We use a patched version of uncrustify to workaround a few bugs, which is why you are also picking up other changes. That's why the easiest way to fix style is to either compile my uncrustify fork or to take a look at the CI :)

@CharlieQLe
Copy link
Contributor Author

Running uncrustify as in the contributing doc shows changes in animate, particle, and blur-base, all of which have nothing to do with this PR. Would you still like me to push changes for those files?

We use a patched version of uncrustify to workaround a few bugs, which is why you are also picking up other changes. That's why the easiest way to fix style is to either compile my uncrustify fork or to take a look at the CI :)

Should be good now!

@ammen99 ammen99 merged commit 76765ca into WayfireWM:master Dec 29, 2023
4 checks passed
ammen99 pushed a commit that referenced this pull request Mar 13, 2024
* Try to make DRM leasing work

* Attempt number two to make this work

* Fix logging and formatting

* Run uncrustify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRM Lease protocol implementation
2 participants