Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(env.ts): no need of double double quotes #372

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

ArnavK-09
Copy link
Contributor

@ArnavK-09 ArnavK-09 commented Nov 9, 2024

resolve #370

its adding double double quote

either we need to remove double quotes from here (1)

return `${entry.key}="${escapedValue}"`

or from here (2)

if (/[\s#=]/.test(value)) {
return `"${escaped}"`
} else {
return escaped
}

as they both are overlapping

its better to remove from (2) so to prevent this

# Enable source maps for easier debugging
NODE_OPTIONS=--enable-source-maps

(im guessing this is invalid syntax for env file, or if IT IS valid, its better to remove double quotes from (1) kindly suggest me

@Nazeofel
Copy link
Contributor

Nazeofel commented Nov 9, 2024

Hi, it should never remove all the quotes, it need to be in double quotes ex
NODE_OPTIONS="--enable-source-maps"

@ArnavK-09
Copy link
Contributor Author

Hi, it should never remove all the quotes, it need to be in double quotes ex NODE_OPTIONS="--enable-source-maps"

yup so this repo aims to do that only, you can test, this is working on my end

@Nazeofel
Copy link
Contributor

Oh jesus I am so sorry, I had read that wrong ! yup, I ll test it out

@Pkmmte Pkmmte merged commit 43f86f4 into Wave-Play:main Nov 16, 2024
2 of 3 checks passed
@Wave-Play Wave-Play locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-robo generating wrong .env file when extensionless is specified
3 participants