fix(robo): reload environment variables in dev mode #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pkmmte
reviewed
Nov 9, 2024
| @@ -308,7 +308,12 @@ export async function buildAsync(command: string | null, config: Config, verbose | |||
|
|
|||
| logger.debug(`> ${pkgManager} ${args.join(' ')}`) | |||
| const childProcess = spawn(pkgManager, args, { | |||
| env: { ...process.env, FORCE_COLOR: '1' }, | |||
| env: { | |||
| // Only pass through essential vars, not the entire env | |||
There was a problem hiding this comment.
Mmm, I'm not sure if this is a good idea. There are several reasons why one would want environment variables to be inherited.
Example 1: Inline variables
Sometimes people pass environment variables inline as part of a script, either as a replacement or as an addition to .env loading.
"dev": "NODE_ENV=test robo dev",
"start": "NODE_ENV=prod robo start"Example 2: Doppler
This is a service I personally use a lot in organizations. Doppler replaces the need for .env files. Similar to example 1, it injects variables to the process expecting it to be inherited.
"dev": "doppler run -- robo dev"Passing only essential variables completely breaks the above two scenarios which are commonly used.
A major type-safe upgrade to our internal `env` now powered by a new `Env` class. This new class can be used to load variables as well as use them safely in a nested fashion.
For consistency with external APIs. We also now accept limited options.
Load functions now also return the newly loaded object. We'll be using this shortly.
Pkmmte
approved these changes
Nov 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes environment variable reloading in dev mode by:
Fixes #302, #352