Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce redundant abstractions #561

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Reduce redundant abstractions #561

merged 8 commits into from
Jun 4, 2024

Conversation

Washi1337
Copy link
Owner

@Washi1337 Washi1337 commented Jun 3, 2024 •
edited
Loading

Removes the following interfaces and moves their definitions+xml doc into their direct class inheritors.

  • IPEFile -> PEFile
  • IPEImage -> PEImage
  • IDotNetDirectory -> DotNetDirectory
  • IMetadata -> MetadataDirectory (SerializedMetadata -> SerializedMetadataDirectory)
  • IExportDirectory -> ExportDirectory
  • IImportedModule -> ImportedModule
  • ITlsDirectory -> TlsDirectory
  • IResourceDirectory -> ResourceDirectory
  • IResourceData -> ResourceData

Closes #445

@Washi1337 Washi1337 added enhancement pe-file Issues related to AsmResolver.PE.File pe Issues related to AsmResolver.PE dotnet Issues related to AsmResolver.DotNet labels Jun 3, 2024
@Washi1337 Washi1337 added this to the 6.0.0 milestone Jun 3, 2024
@Washi1337 Washi1337 merged commit 9ecc97a into development Jun 4, 2024
1 check passed
@Washi1337 Washi1337 deleted the feature/reduce-redundant-abstractions branch June 12, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dotnet Issues related to AsmResolver.DotNet enhancement pe Issues related to AsmResolver.PE pe-file Issues related to AsmResolver.PE.File
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Washi1337