Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Accessors for Semantic Methods #555

Merged
merged 3 commits into from
May 15, 2024
Merged

Set Accessors for Semantic Methods #555

merged 3 commits into from
May 15, 2024

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented May 12, 2024

Should these set accessors modify MethodDefinition.Semantics too?

@Washi1337
Copy link
Owner

This should be already handled by MethodSemanticsCollection. If not, then this should be considered a bug.

@Washi1337 Washi1337 added enhancement dotnet Issues related to AsmResolver.DotNet labels May 13, 2024
@Washi1337 Washi1337 added this to the 6.0.0 milestone May 13, 2024
@ds5678
Copy link
Contributor Author

ds5678 commented May 13, 2024

This should be already handled by MethodSemanticsCollection. If not, then this should be considered a bug.

This is correct. I added a unit test to make sure.

@Washi1337 Washi1337 merged commit c5802a6 into Washi1337:development May 15, 2024
1 check passed
@Washi1337
Copy link
Owner

Thanks for verifying!

@ds5678 ds5678 deleted the property-definition-set-accessors branch May 15, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dotnet Issues related to AsmResolver.DotNet enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ds5678 @Washi1337