Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve resource entry order based on ID #553

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Preserve resource entry order based on ID #553

merged 2 commits into from
Apr 28, 2024

Conversation

Washi1337
Copy link
Owner

@Washi1337 Washi1337 commented Apr 19, 2024 •
edited
Loading

  • Renames ResourceDirectory::AddOrReplaceEntry to InsertOrReplaceEntry
  • Renames IWin32Resource::AddToDirectory to InsertIntoDirectory

Closes #532

@Washi1337 Washi1337 added bug pe Issues related to AsmResolver.PE win32resources Issues related to AsmResolver.PE.Win32Resources labels Apr 19, 2024
@Washi1337 Washi1337 added this to the 6.0.0 milestone Apr 19, 2024
@Washi1337 Washi1337 linked an issue Apr 19, 2024 that may be closed by this pull request
IWin32Resource::WriteToDirectory does not take sorting into account #532
Closed
@Washi1337 Washi1337 force-pushed the feature/win32-insert-into-dir branch from 269d0fb to e788c65 Compare April 19, 2024 16:08
@Washi1337 Washi1337 merged commit 0780c51 into development Apr 28, 2024
1 check passed
@Washi1337 Washi1337 deleted the feature/win32-insert-into-dir branch April 28, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug pe Issues related to AsmResolver.PE win32resources Issues related to AsmResolver.PE.Win32Resources
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

IWin32Resource::WriteToDirectory does not take sorting into account
1 participant
@Washi1337