Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress resource data deduplication #492

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Suppress resource data deduplication #492

merged 5 commits into from
Nov 1, 2023

Conversation

Washi1337
Copy link
Owner

@Washi1337 Washi1337 commented Oct 31, 2023 •
edited
Loading

  • Add MetadataBuilderFlags.NoResourceDataDeduplication to stop AsmResolver from reusing data offsets for embedded manifest resources.
  • Add bounds-check for reading embedded resource data with malicious / invalid sizes.
  • Normalize newlines in unit tests.

@Washi1337 Washi1337 added bug enhancement dotnet Issues related to AsmResolver.DotNet labels Oct 31, 2023
@Washi1337 Washi1337 added this to the 5.5.0 milestone Oct 31, 2023
@Washi1337 Washi1337 merged commit da9798e into development Nov 1, 2023
1 check passed
@Washi1337 Washi1337 deleted the feature/resource-data-deduplication branch November 1, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug dotnet Issues related to AsmResolver.DotNet enhancement
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Washi1337