Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading LProcRef and ProcRef symbols #368

Merged
merged 3 commits into from
Nov 5, 2022

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Oct 16, 2022

No description provided.

@Washi1337 Washi1337 added enhancement pdb Issues related to AsmResolver.Symbols.Pdb labels Oct 16, 2022
@Washi1337 Washi1337 added this to the 5.0.0 milestone Oct 16, 2022
@Washi1337
Copy link
Owner

Washi1337 commented Oct 16, 2022

Would be nice if there are some unit test, to ensure that we don't break the implementation in the future. The SimpleDll.pdb resource in the pdb tests project has some S_PROCREF and S_LPROCREF entries that we can verify.

Other than that, LGTM!

Copy link
Owner

@Washi1337 Washi1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Washi1337 Washi1337 merged commit 87fd1ac into Washi1337:development Nov 5, 2022
@ds5678 ds5678 deleted the procedure-reference-symbol branch July 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement pdb Issues related to AsmResolver.Symbols.Pdb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants