-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Throw on generic context GetTypeArgument + Add: GenericContext From methods #225
Merged
Washi1337
merged 11 commits into
Washi1337:development
from
JPaja:issue/generic-context-publisher
Nov 28, 2021
Merged
Fix: Throw on generic context GetTypeArgument + Add: GenericContext From methods #225
Washi1337
merged 11 commits into
Washi1337:development
from
JPaja:issue/generic-context-publisher
Nov 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPaja
changed the title
Fix: Throw on generic context GetTypeArgument
Fix: Throw on generic context GetTypeArgument + Add: GenericContext FromSpecification methods
Nov 28, 2021
JPaja
changed the title
Fix: Throw on generic context GetTypeArgument + Add: GenericContext FromSpecification methods
Fix: Throw on generic context GetTypeArgument + Add: GenericContext From methods
Nov 28, 2021
Washi1337
requested changes
Nov 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things but otherwise LGTM
Washi1337
approved these changes
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when we want to partially replace generic values (only Vars, or only MVars) on methods that contains both, we don't want to throw error when second provider is missing