Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Throw on generic context GetTypeArgument + Add: GenericContext From methods #225

Merged
merged 11 commits into from
Nov 28, 2021

Conversation

JPaja
Copy link
Contributor

@JPaja JPaja commented Nov 27, 2021

In case when we want to partially replace generic values (only Vars, or only MVars) on methods that contains both, we don't want to throw error when second provider is missing

@JPaja JPaja changed the title Fix: Throw on generic context GetTypeArgument Fix: Throw on generic context GetTypeArgument + Add: GenericContext FromSpecification methods Nov 28, 2021
@JPaja JPaja changed the title Fix: Throw on generic context GetTypeArgument + Add: GenericContext FromSpecification methods Fix: Throw on generic context GetTypeArgument + Add: GenericContext From methods Nov 28, 2021
@Washi1337 Washi1337 added this to the 4.8.0 milestone Nov 28, 2021
@Washi1337 Washi1337 added dotnet Issues related to AsmResolver.DotNet enhancement labels Nov 28, 2021
Copy link
Owner

@Washi1337 Washi1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things but otherwise LGTM

src/AsmResolver.DotNet/Signatures/GenericContext.cs Outdated Show resolved Hide resolved
src/AsmResolver.DotNet/Signatures/GenericContext.cs Outdated Show resolved Hide resolved
src/AsmResolver.DotNet/Signatures/GenericContext.cs Outdated Show resolved Hide resolved
src/AsmResolver.DotNet/Signatures/GenericContext.cs Outdated Show resolved Hide resolved
@Washi1337 Washi1337 merged commit d908d89 into Washi1337:development Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Issues related to AsmResolver.DotNet enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants