Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Multiple generics support in TypeNameParser #223

Merged
merged 3 commits into from
Nov 28, 2021
Merged

Fix: Multiple generics support in TypeNameParser #223

merged 3 commits into from
Nov 28, 2021

Conversation

JPaja
Copy link
Contributor

@JPaja JPaja commented Nov 27, 2021

Fixes #222

@JPaja JPaja changed the title Fix: Multiple generics support in TypeNameParser [WIP] Multiple generics support in TypeNameParser Nov 27, 2021
@JPaja JPaja changed the title [WIP] Multiple generics support in TypeNameParser Multiple generics support in TypeNameParser Nov 27, 2021
@JPaja JPaja changed the title Multiple generics support in TypeNameParser Fix: Multiple generics support in TypeNameParser Nov 27, 2021
@JPaja
Copy link
Contributor Author

JPaja commented Nov 27, 2021

Ok so my conclusion from this is
when generics are just in 1 braces they cannot have assembly info
[Generic1, Generic2]
but when its double then it can have commas inside
[[Generic, Assembly, Version=123], [Generic2, Assembly2, Version=333]]

@Washi1337 Washi1337 merged commit 8977a4d into Washi1337:development Nov 28, 2021
@Washi1337
Copy link
Owner

Thanks, good catch!

@Washi1337 Washi1337 added bug dotnet Issues related to AsmResolver.DotNet labels Nov 28, 2021
@Washi1337 Washi1337 added this to the 4.8.0 milestone Nov 28, 2021
@JPaja JPaja deleted the issue/multigeneric-typenameparser branch November 28, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug dotnet Issues related to AsmResolver.DotNet
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JPaja @Washi1337