Skip to content
This repository has been archived by the owner on Feb 14, 2018. It is now read-only.

Abstract persistence into Store classes -- FileStore and CouchStore. #204

Merged
merged 13 commits into from
Apr 30, 2012

Conversation

harlantwood
Copy link

CouchDB stores data as similarly as possible to the file system pattern, using the path (relative to the application root) as the key, and the file content as the value. Values are base64 encoded in the case of binary data like favicons.

CouchDB stores similarly to the file system, using the path *relative* to the application root as the key, and the file content as the value, base64 encoded for binary data.
@harlantwood harlantwood mentioned this pull request Apr 23, 2012
@harlantwood
Copy link
Author

Side note: there is one test that fails on my (OSX) machine -- it was failing prior to cutting my branch as well:

1) testing javascript with mocha should run with no failures
  Failure/Error: failures.should be('0'), trouble
    []
  # ./spec/integration_spec.rb:305:in `block (2 levels) in <top (required)>'

@harlantwood
Copy link
Author

Good to chat tonight. I incorporated the changes that came up, plus a few other minor improvements. Tests pass (except for the unrelated ./spec/integration_spec.rb:305), and smoke tests on both file storage and couch seem good. I'd like to get in more testing (probably this weekend), but it's also fine to pull these changes now if you'd like. I'll try to respond quickly if bugs show up.

@harlantwood
Copy link
Author

I'll do some testing on this tomorrow and get it wrapped up by the end of the weekend.

@harlantwood
Copy link
Author

I created two test apps:

Both seem to work well in every smoke test I can think of:

  • Creating pages
  • Dragging and dropping content between pages
  • Dragging and dropping a page from one site into the other
  • Uploading images
  • Creating favicons
  • Claiming sites
  • "Recent changes" pages

Conclusion: ready to pull.

@harlantwood
Copy link
Author

Fixed a bug that effected the couch version.

@WardCunningham WardCunningham merged commit b6ccece into WardCunningham:master Apr 30, 2012
@WardCunningham
Copy link
Owner

Happy to have this code in the project. Thanks so much for your efforts.

@harlantwood
Copy link
Author

Thanks Ward. It's great to be working on a project I believe in so strongly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants