Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/teacher dashboard #146

Merged
merged 7 commits into from
Jan 25, 2018
Merged

Feature/teacher dashboard #146

merged 7 commits into from
Jan 25, 2018

Conversation

basvtholt
Copy link
Collaborator

Closes #133
Closes #135

(2, "[email protected]", "Jane Doe", "$2a$04$FYZXxiv7A74rX33gfs2m/.AGqhQ/unlJCB2nHLRiuHCVlECcyLyb6", 1, '654321'),
(3, "[email protected]", "Administrator", "$2a$04$FYZXxiv7A74rX33gfs2m/.AGqhQ/unlJCB2nHLRiuHCVlECcyLyb6", 1, '987555'),
(4, "[email protected]", "John Doe", "$2a$04$FYZXxiv7A74rX33gfs2m/.AGqhQ/unlJCB2nHLRiuHCVlECcyLyb6", 1, '123456');
=======
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts first

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to push them

@@ -1,31 +1,26 @@
<div ng-init="init()">
<div ng-init="$ctrl.onInit()">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needen

@@ -1,18 +1,19 @@
<div ng-init="init()">
<div ng-init="$ctrl.onInit()">
<table layout-fill>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

</div>

<!-- $scope.items = [1, 2, 3, 4, 5, 6, 7];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove this outcommented code

Copy link
Owner

@Want100Cookies Want100Cookies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge if the tests succeed.

@cassshh cassshh merged commit 0902a01 into develop Jan 25, 2018
@cassshh cassshh deleted the feature/teacher_dashboard branch January 25, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants