Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to discern between んよう or にょう when converting romaji to kana (Support for n') #38

Closed
maesierra opened this issue Jun 14, 2014 · 1 comment
Labels

Comments

@maesierra
Copy link

IE: kinyou could be both きにょう or きんよう. When using IME that's not an issue because the typing is [k i n y o u] for きにょう and [k i n n y o u] for きんよう. But right now when using toHiragana "kinnyou" becames "きんにょ"
On romaji usually n' is used to mark a single ん when followed by a や/ゆ/よ

@vietqhoang vietqhoang added the bug label Jun 15, 2014
@vietqhoang
Copy link
Member

This is a valid issue. I believe toHiragana is tied with IME function. Perhaps add another logic that will transliterate the n correctly and add an optional flag if toHiragana is being used for the IME? In other words, have toHiragana to default n' as single ん.

Sithdown added a commit to Sithdown/WanaKana that referenced this issue Aug 31, 2015
Sithdown added a commit to Sithdown/WanaKana that referenced this issue Aug 31, 2015
Sithdown added a commit to Sithdown/WanaKana that referenced this issue Aug 31, 2015
@DJTB DJTB closed this as completed in 4b4476f Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants