Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READY: add fail fast to checkmate stage of CI/CD #1442

Merged
merged 4 commits into from
Aug 30, 2024
Merged

READY: add fail fast to checkmate stage of CI/CD #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c58bc6
feat: add fail fast to `checkmate` stage of CI/CD
SRetip Aug 29, 2024
2a75dd6
+test
SRetip Aug 29, 2024
8a70e14
revert
SRetip Aug 29, 2024
cf4c244
feat: add comments
SRetip Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/standard_rust_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ jobs :
continue-on-error: true
- name: Check the modules dependencies
run: cargo +nightly udeps --all-targets --manifest-path ${{ inputs.manifest_path }}
continue-on-error: true
# This part means that all previous steps will be executed and workflow will not stop if they fail, but not this one.
continue-on-error: false

# release:
# if: contains( inputs.commit_message, '+test' ) || contains( inputs.commit_message, 'merge' )
Expand Down Expand Up @@ -125,6 +126,9 @@ jobs :
# run: cargo miri test --manifest-path ${{ inputs.manifest_path }}

will_test :
# This section ensures that `job` `will_test` will only be executed after `checkmate` and if `checkmate` fails, no tests will be run.
needs:
- checkmate
if : contains( inputs.commit_message, '+test' ) || inputs.commiter_username == 'web-flow' || startsWith( inputs.commit_message, 'merge' )
concurrency :
group : standard_rust_push_${{ inputs.module_name }}_${{ github.ref }}_${{ matrix.os }}
Expand Down
6 changes: 5 additions & 1 deletion module/move/willbe/template/workflow/standard_rust_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ jobs :
continue-on-error: true
- name: Check the modules dependencies
run: cargo +nightly udeps --all-targets --manifest-path ${{ inputs.manifest_path }}
continue-on-error: true
# This part means that all previous steps will be executed and workflow will not stop if they fail, but not this one.
continue-on-error: false

# release:
# if: contains( inputs.commit_message, '+test' ) || contains( inputs.commit_message, 'merge' )
Expand Down Expand Up @@ -125,6 +126,9 @@ jobs :
# run: cargo miri test --manifest-path ${{ inputs.manifest_path }}

will_test :
# This section ensures that `job` `will_test` will only be executed after `checkmate` and if `checkmate` fails, no tests will be run.
needs :
- checkmate
if : contains( inputs.commit_message, '+test' ) || inputs.commiter_username == 'web-flow' || startsWith( inputs.commit_message, 'merge' )
concurrency :
group : standard_rust_push_${{ inputs.module_name }}_${{ github.ref }}_${{ matrix.os }}
Expand Down
Loading