Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOT READY: Index macros #1398

Merged
merged 15 commits into from
Jul 8, 2024
Merged

NOT READY: Index macros #1398

merged 15 commits into from
Jul 8, 2024

Conversation

Inkvisto
Copy link
Contributor

@Inkvisto Inkvisto commented Jul 2, 2024

No description provided.

@wtools-bot
Copy link
Collaborator

To maintain stability of the module the repository uses 3-stages system to forward changes from an unstable branch to a stable.
The unstable branch is alpha. All user pull requests should be opened to this branch.
The staging branch is beta. Changes to this branch are forwarded by a pull request from branch alpha automatically.
The stable branch is master. Changes to this branch are forwarded by a pull request from branch beta automatically.

The pull request was automatically converted to draft.
Please, change base branch taking into account the described system alpha -> beta -> master.

@Inkvisto Inkvisto changed the base branch from master to alpha July 2, 2024 08:09
Wandalen
Wandalen requested changes Jul 8, 2024
View reviewed changes
module/core/derive_tools_meta/src/lib.rs Outdated
#[ proc_macro_derive
(
Index,
attributes(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

module/core/derive_tools_meta/src/derive/index.rs Outdated
Result
};

pub fn index( input : proc_macro::TokenStream ) -> Result< proc_macro2::TokenStream > {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

module/core/derive_tools_meta/src/derive/index.rs Outdated

fn generate_struct_tuple_fields
(
item_name: &syn::Ident,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

@Wandalen Wandalen marked this pull request as ready for review July 8, 2024 12:27
@Wandalen Wandalen merged commit e667a7e into Wandalen:alpha Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wandalen Wandalen Wandalen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Inkvisto @wtools-bot @Wandalen