Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT READY : add join_path function #1288

Merged
merged 8 commits into from
May 13, 2024
Merged

Conversation

SupperZum
Copy link
Collaborator

No description provided.

for path in paths
{

let mut path = path.replace( '\\', "/" );
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalize should be called here

}

#[ test ]
fn more_complicated_cases_5()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does original version have such case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SupperZum SupperZum changed the title READY : add join_path function NOT READY : add join_path function Apr 10, 2024
@SupperZum SupperZum changed the title NOT READY : add join_path function READY : add join_path function May 1, 2024
@Wandalen
Copy link
Owner

Wandalen commented May 1, 2024

@SupperZum fix conflicts, please

@Wandalen Wandalen changed the title READY : add join_path function NOT READY : add join_path function May 1, 2024
@SupperZum SupperZum changed the title NOT READY : add join_path function READY : add join_path function May 1, 2024
@Wandalen Wandalen changed the title READY : add join_path function NOT READY : add join_path function May 3, 2024
@Wandalen
Copy link
Owner

Wandalen commented May 3, 2024

@SupperZum fix conflicts, please

@SupperZum SupperZum changed the title NOT READY : add join_path function READY : add join_path function May 6, 2024
@Wandalen Wandalen changed the title READY : add join_path function NOT READY : add join_path function May 10, 2024
@SupperZum SupperZum changed the title NOT READY : add join_path function READY : add join_path function May 10, 2024
@Wandalen Wandalen changed the title READY : add join_path function NOT READY : add join_path function May 11, 2024
@Wandalen
Copy link
Owner

it's failing @SupperZum

@Wandalen Wandalen merged commit 070a33b into Wandalen:alpha May 13, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants