READY: (wca): Re-work help generation and removing unsafe code #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-use help for dot help and other variants Re-work help related things in aggregator to be removed after use
…o wca_re_work_help_generation
The help command output in the test file commands_aggregator/help.rs has been revised. The updated test now expects an output that starts with "Help command", aligning it with the new format changes.
Barsik-sus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of reusability and efficiency, we've optimized the generate_help_content function to generate all variants of help content. This change ensures that help-related elements in the aggregator are removed after use.
Furthermore, we have taken bold steps to uphold code safety standards by eliminating unsafe code in the Context structure.
These steps forward embody our commitment to producing modular, safe, and efficient code in our project.