READY (willbe): add readme.headers.generate command
#1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wandalen
requested changes
Feb 26, 2024
| use crate::path::AbsolutePath; | ||
|
|
||
| /// Aggregates two commands: `generate_modules_headers` & `generate_main_header` | ||
| pub fn readme_headers_generate( ( _, _ ) : ( wca::Args, wca::Props ) ) -> Result< () > |
Wandalen
changed the title
readme.headers.generate commandreadme.headers.generate command
|
@SRetip get completed |
|
what is with this? @SRetip |
I can't complete this |
SRetip
changed the title
readme.headers.generate commandreadme.headers.generate command
Barsik-sus
suggested changes
May 30, 2024
| @@ -114,21 +178,40 @@ mod private | |||
| /// [](https://docs.rs/wtools) | |||
| /// <!--{ generate.main_header.end }--> | |||
| /// ``` | |||
| pub fn readme_header_renew( path : AbsolutePath ) -> Result< () > | |||
| pub fn readme_header_renew( path : AbsolutePath ) -> Result< MainHeaderRenewReport, ( MainHeaderRenewError, MainHeaderRenewReport ) > | |||
There was a problem hiding this comment.
It would be better to swap the error and report to follow the sequence of the other commands, wouldn't it?
| { | ||
| use std::fmt::{Display, Formatter}; | ||
| use error_tools::{ Result, err }; | ||
| use crate::_path::AbsolutePath; |
There was a problem hiding this comment.
This seems to be not in line with the convention
| use error_tools::{ Result, err }; | ||
| use crate::_path::AbsolutePath; | ||
| use crate::action; | ||
| use crate::action::{MainHeaderRenewReport, ModulesHeadersRenewReport}; |
| { | ||
| report.main_header_renew_report = r; | ||
| } | ||
| Err( ( error, r) ) => |
There was a problem hiding this comment.
Suggested change
| Err( ( error, r) ) => | |
| Err( ( error, r ) ) => |
| { | ||
| report.modules_headers_renew_report = r; | ||
| } | ||
| Err( ( error, r) ) => |
There was a problem hiding this comment.
Suggested change
| Err( ( error, r) ) => | |
| Err( ( error, r ) ) => |
SRetip
changed the title
readme.headers.generate commandreadme.headers.generate command
SRetip
changed the title
readme.headers.generate commandreadme.headers.generate command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new command ( aggregation of
readme.modules.headers.generate&readmde.header.generate)