Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Can't read property "disableSessionCreation" of undefined #214

Merged
merged 2 commits into from
Dec 19, 2019
Merged

BUG: Can't read property "disableSessionCreation" of undefined #214

merged 2 commits into from
Dec 19, 2019

Conversation

mmv08
Copy link
Contributor

@mmv08 mmv08 commented Dec 19, 2019

I accidentally broke walletconnect web3-provider with this PR by not checking if options object is defined: #208

This PR fixes that
Screenshot 2019-12-19 at 11 51 00

Copy link
Contributor

@pedrouid pedrouid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrouid pedrouid merged commit b9a5dbf into WalletConnect:master Dec 19, 2019
@pedrouid
Copy link
Contributor

Thanks @mikheevm for this fix 🙌 I've published this fix v1.0.0-beta.42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants