refactor: Add Redux data layer and authentication using it #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonMeade
had a problem deploying
to
github-pages
GitHub Actions
Failure
dvdokkum
approved these changes
Jun 19, 2024
jakebromberg
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes no issue
Summary
This PR introduces the Redux library to our frontend for the DJ site, increasing readability, separation of concerns, and extendability.
To start, this strips back the app to login functionality only, without user management via the admin dashboard. Approvals and reviews should focus on good code style, readability, and login functionality, while later PRs will be concerned with other 'pages' within the dashboard.
Testing
To test this branch, pull it down, remove lines 4 through 8 of next.config.mjs (leave only reactStrictMode:false behind), and run
npm run dev, and visit localhost. Building should complete once it is merged with main.Verified that all functionality promised in this branch exists on dev. Build completes successfully.
We expect build to succeed and deploy to skip, as we do not wish to deploy to pages from a pull request.