Convert to a Next + Redux app #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this, Jackson. Couple suggestions:
|
|
Noting here that I will be writing more extensive documentation and giving y'all a full rundown on Saturday; while this is in a draft state don't worry about reviewing. |
|
Got it!
…On Tue, Jan 30, 2024 at 12:38 PM Jackson M Meade ***@***.***> wrote:
Noting here that I will be writing more extensive documentation and giving
y'all a full rundown on Saturday; while this is in a draft state don't
worry about reviewing.
—
Reply to this email directly, view it on GitHub
<#35 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADM2VS6H4GYLOJGNBEHASLYRFK53AVCNFSM6AAAAABCQTG2W6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXHA2TGNJRGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Why is the AWS sdk documentation so atrocious? Like, do you want us to use this or not?
app/dashboard/admin/page.tsx
Outdated
|
|
||
| const AdminPage = () => { | ||
| return ( |
There was a problem hiding this comment.
Could you fix the indentation, please?
| import { getter } from "@/lib/services"; | ||
| import { useEffect } from "react"; | ||
| import { toast } from "sonner"; | ||
|
|
||
| export default function VerifyPage() { | ||
|
|
||
| const user = useSelector(getAuthenticatedUser); | ||
| const dispatch = useDispatch(); | ||
|
|
||
| useEffect(() => { | ||
| console.log("mounted"); | ||
|
|
||
| const process = async (e: KeyboardEvent) => { |
There was a problem hiding this comment.
Could you rename this to something more descriptive like processKeyboardInput or something?
| import { getter } from "@/lib/services"; | ||
| import { useEffect } from "react"; | ||
| import { toast } from "sonner"; | ||
|
|
||
| export default function VerifyPage() { | ||
|
|
||
| const user = useSelector(getAuthenticatedUser); | ||
| const dispatch = useDispatch(); | ||
|
|
||
| useEffect(() => { | ||
| console.log("mounted"); | ||
|
|
||
| const process = async (e: KeyboardEvent) => { | ||
| if ((e as KeyboardEvent).key === 'v') { |
There was a problem hiding this comment.
Could you leave a comment that documents why v is special? Is this v for verify?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.