Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission callbacks to REST API endpoints #39

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add permission callbacks to REST API endpoints #39

wants to merge 1 commit into from

Conversation

joemcgill
Copy link

This fixes a notice thrown since WP 5.5 when a REST route is registered
without explicitly adding a permission callback.

@joemcgill
Add permission callbacks to REST API endpoints
be90781 
This fixes a notice thrown since WP 5.5 when a REST route is registered
without explicitly adding a permission callback.
@joemcgill joemcgill mentioned this pull request Nov 10, 2020
Open
sun
sun suggested changes Jan 27, 2021
View reviewed changes
Copy link

@sun sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only perform the necessary changes and do not include any changes to unrelated lines; i.e., please revert the coding style changes - you may create a separate PR for them, but they are out of scope for this change and therefore should not be included.

jhhazelaar
jhhazelaar reviewed Aug 26, 2021
View reviewed changes
Copy link

@jhhazelaar jhhazelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

jhhazelaar
jhhazelaar reviewed Aug 26, 2021
View reviewed changes
Copy link

@jhhazelaar jhhazelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed whitespaces

@jhhazelaar jhhazelaar mentioned this pull request Aug 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhhazelaar jhhazelaar jhhazelaar left review comments

@sun sun sun requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joemcgill @sun @jhhazelaar