fix: [SUP-1501] stop setting content-length explicitly to avoid truncating responses #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t set correctly. Add wovnEncodingOverride debug query parameter to force the response encoding when wovnjava receives the original HTML. wovnDebugMode now shows the request logs as a HTML comment for debugging purposes.
bstewart00
changed the title
aw-leigh
approved these changes
Jul 6, 2022
iwai-wovn
approved these changes
Jul 6, 2022
bstewart00
force-pushed
the
fix/truncated_response_and_logging
branch
from
637b99f
to
5fec2f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wovnio.atlassian.net/browse/SUP-1501?focusedCommentId=49877
Setting Content-Length header isn't mandatory but can lead to truncation if not set correctly.
Also added some convenience debugging utilities while investigating this issue:
wovnEncodingOverridedebug query parameter to force the response encoding when wovnjava receives the original HTML. Only available in debug mode. There is anencodingsetting in the wovnjava configuration file, but this allows us to change the encoding for a single request.wovnDebugModenow shows the request logs as a HTML comment for debugging purposes (when debug mode is enabled in settings)