-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add outboundProxyHost/Port settings to enable communication with html swapper via a proxy. #171
Conversation
… swapper via a proxy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But have we confirmed that the proxy client is using is HTTP and not SOCKS or some other type?
No, i'm just making an assumption. Who uses SOCKS? 😛 I guess we should check though. |
We can make another release later if we need SOCKS support. |
feature: Add outboundProxyHost/Port settings to enable communication with html swapper via a proxy. (#171) 70f56e2 Brett Stewart <[email protected]> Apr 29, 2021 18:13
https://wovnio.atlassian.net/browse/ST-881
version 1.2.0-java7
Add outboundProxyHost/Port settings to enable communication with html swapper via a proxy.
Unfortunately we already have a
useProxy
setting which is used for a different purpose (when the wovnjava request is coming from a reverse proxy and doesn't reflect the true browser URL). I've tried to be explicit that this setting is for proxying outbound requests.