Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add outboundProxyHost/Port settings to enable communication with html swapper via a proxy. #171

Merged
merged 10 commits into from
Apr 29, 2021

Conversation

bstewart00
Copy link
Contributor

@bstewart00 bstewart00 commented Apr 28, 2021

https://wovnio.atlassian.net/browse/ST-881

version 1.2.0-java7

Add outboundProxyHost/Port settings to enable communication with html swapper via a proxy.

Unfortunately we already have a useProxy setting which is used for a different purpose (when the wovnjava request is coming from a reverse proxy and doesn't reflect the true browser URL). I've tried to be explicit that this setting is for proxying outbound requests.

<init-param>
  <param-name>outboundProxyHost</param-name>
  <param-value>proxy.company.com</param-value>
</init-param>
<init-param>
  <param-name>outboundProxyPort</param-name>
  <param-value>8080</param-value>
</init-param>

Copy link
Contributor

@zeyuwu zeyuwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But have we confirmed that the proxy client is using is HTTP and not SOCKS or some other type?

@bstewart00
Copy link
Contributor Author

Looks good. But have we confirmed that the proxy client is using is HTTP and not SOCKS or some other type?

No, i'm just making an assumption. Who uses SOCKS? 😛 I guess we should check though.

@bstewart00 bstewart00 changed the title Add outboundProxyHost/Port settings to enable communication with html swapper via a proxy. feature: Add outboundProxyHost/Port settings to enable communication with html swapper via a proxy. Apr 29, 2021
@bstewart00
Copy link
Contributor Author

We can make another release later if we need SOCKS support.

@bstewart00 bstewart00 merged commit 70f56e2 into java7_support Apr 29, 2021
@bstewart00 bstewart00 deleted the feature/support-proxy branch April 29, 2021 09:13
bstewart00 added a commit that referenced this pull request May 7, 2021
feature: Add outboundProxyHost/Port settings to enable communication with html swapper via a proxy. (#171)	70f56e2	Brett Stewart <[email protected]>	Apr 29, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants