Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
neutral_ratios
andneutral_ratios_iter
.smact_filter
now takes a stoich argument, so users can supply a list of stoichiometries for each site. This can now allow users to filter for charge-neutral compositions of a particular stoichiometric ratio.Fixes # (issue)
Type of change
How Has This Been Tested?
Re-ran the test suite to check that the tests aren't broken by the update to
smact_filter
.The new functionality with the stoichs argument to the
smact_filter
function has had additional tests written to verify that it works.Test Configuration:
Tests also pass the following OSs and python versions based of Github Actions:
Checklist: