Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to merged scoreboards #59

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mpsijm
Copy link
Contributor

@mpsijm mpsijm commented May 10, 2024

The idea is that I also want to add the merged scoreboards, e.g. for all BAPC preliminaries, or for the shared FPCs. I already had this idea for some time, but I'm still not sure what's the best way to add multiple scoreboards to our archive 😛 For now, I've added it as second icon in the column with the scoreboards, but that looks inconsistent. On the other hand, I also don't want to add a whole extra column just for these few recent years where this is relevant. Opinions are welcome 😄

Here's how it currently looks:

image

image

Apparently, I had already uploaded the merged scoreboard of DAPC 2021 when I was playing with this earlier. I'll also add the merged scoreboards of other DAPCs (and maybe I can still do last year's FPC, which we shared with Amsterdam and Eindhoven), but I'd first like to get consensus on the formatting 🙂

@mpsijm mpsijm requested review from verwoerd and maartenweyns May 10, 2024 16:03
@mpsijm
Copy link
Contributor Author

mpsijm commented May 11, 2024

Documenting @07joshua03's feedback that he gave in-person:

  • The jarred column looks awful 😄
  • The merge icon isn't optimal, but it's probably one of the better options, not sure what else it could be.
  • What if we have a little pop-over when there are multiple scoreboards?

I'm intrigued by the last idea, so I tried something: how's this? 😄

image

The pop-over / drop-down shows onmouseenter, and disappears onmouseleave. Funnily enough, this also works on mobile, because clicking on the arrow moves the virtual cursor to be over the arrow-icon 😛

@mpsijm mpsijm force-pushed the merged-scoreboard branch from 5382365 to a6b8313 Compare June 12, 2024 13:15
@verwoerd
Copy link
Contributor

Why not just create an extra column for icons, so we keep it single click. interaction.

I also would like to have a disclaimer added to the merged scoreboards to address that a merged standing is 100% comparable due to different situations and rules at a contest. Something like this:

The merged scoreboard is indicative and created after the contest was held. Teams had no access to this information during the contest and only had access to their own scoreboard. The rules per institution may differ on materials brought. The general clarifications sent may differ per institution. The duration of the contest, freeze time, physical situation and team requirements can differ by institution.

It might also be more proper and informative to have the scoreboards of the different institutions in different groups (like with spectators and companies). Maybe merge the two scoreboards in a single DOMjudge scoreboad like:

  • merged scoreboard
  • Delft scoreboard
  • Delft Spectators
  • Delft Companies
  • Eindhoven scoreboard
  • ....

This will mean that all contestant teams will appear twice (I would leave out the spectators and companies out of the merged scoreboard). This will make it so we only need a single scoreboard button and file and all information is included like the local standing.

@mpsijm
Copy link
Contributor Author

mpsijm commented Jun 13, 2024

Why not just create an extra column for icons, so we keep it single click interaction

As mentioned in the description of this PR, I "don't want to add a whole extra column just for these few recent years where this is relevant." Additionally, if we have more than one "extra scoreboard" (e.g. "merged" and "online", but also possibly scoreboards from other institutions), visitors will need an extra click to select between these anyway.

I also would like to have a disclaimer added to the merged scoreboards to address that a merged standing is [not?] 100% comparable

Agreed, that's a good idea 😄

Maybe merge the two scoreboards in a single DOMjudge scoreboad like: [...]

If you mean "merge all scoreboards into a single HTML page": I would like to avoid that, since that's quite a bit of effort. It's easier if we can simply download the scoreboard from DOMjudge (which can be exported as a ZIP from the contest settings page nowadays) and host it as-is from an URL in the YAML config.
I would be okay with adding some kind of intermediate "index page" that lists the different scoreboards that we have (which is currently only "Delft", "merged", and "online" for FPC 2024, for instance, but can also include other institutions if we would like). But that index page would be quite empty otherwise, and also requires a two-click interaction (just like the pop-over, so then I prefer the pop-over).

I would leave out the spectators and companies out of the merged scoreboard

That is currently already the case 🙂 The merged scoreboard is created using a custom DOMjudge command, currently maintained at https://github.com/mpsijm/domjudge/blob/scoreboardmerge_new/webapp/src/Command/ScoreboardMergeCommand.php, and we make sure to only include eligible participant categories.

@verwoerd
Copy link
Contributor

The column problem should not be an issue. There are currently already columns that are unused in the DAPC/FPC category like website that get filtered out if it is not present. If in the future we keep adding a merged scoreboard to the site this validates the use of adding an extra column. I think that hosting separate scoreboards of other institutions should be outside the scope of the CHipCie website, but rather fits the PCF.

We should actually rethink how we host scoreboards. Having multiple scoreboards with duplicated assets (including unused fonts, images etc), when our builds are having problems with space is not the way forward. Having the DOMjudge skin is not necessarily mandatory. Hugo should be able to generate the html scoreboard files with their record system (with maybe a dropdown to select different selections). These records should can easily be scripted to be generated. I might try to create a prototype in the coming months.

@mpsijm
Copy link
Contributor Author

mpsijm commented Jun 13, 2024

The column problem should not be an issue. [...] If in the future we keep adding a merged scoreboard to the site this validates the use of adding an extra column.

All right 🙂 Then the question becomes: which icons do we use for the merged scoreboard and the online spectator scoreboard?

I think that hosting separate scoreboards of other institutions should be outside the scope of the CHipCie website, but rather fits the PCF.

That's fair, in that case I was confused because you listed Eindhoven in your previous comment 😛 I guess hosting additional scoreboards at https://pcf.community/wiki/contests/ makes sense, but this currently only links to the original websites, and having two separate archives to maintain also feels unhandy 🤔

Having multiple scoreboards with duplicated assets (including unused fonts, images etc), when our builds are having problems with space is not the way forward.

I don't think LFS storage space/bandwidth is the main concern with these scoreboards. The problem set ZIPs are hundreds of megabytes each, but the scoreboards "only" take up to a few megabytes each, and in most cases index.html is the bulk of it, not the other assets:

NWERC 2023 FPC 2024
image image

I have also been thinking about deduplicating assets (particularly the webfonts) by symlinking them to a shared version or something. But again, I don't feel like they contribute enough to storage space to make it worth investing time in this.
In that same regard, I don't think reinventing the wheel for generating scoreboards using Hugo is necessary, and I do prefer to keep the DOMjudge skin 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants