Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace openAssetChooser and assetSelected events #2615

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Replace openAssetChooser and assetSelected events #2615

merged 3 commits into from
Sep 16, 2020

Conversation

geoffreykwan
Copy link
Member

Make sure opening the asset chooser and selecting an asset works in all these places in the Authoring Tool

  • Authoring Student Notebook Starter Text
  • Authoring Teacher Notebook Starter Text
  • Authoring Unit Info Unit Icon. Click Edit, then click Upload.
  • Authoring advanced Script Filename
  • Edit Project Rubric
  • Edit Step Rubric
  • Edit Component Rubric
  • Animation component Objects (Image, Image Moving Left, Image Moving Right)
  • Concept Map (Background Image, Nodes)
  • Draw (Background Image, Stamps)
  • Embedded (Model File Name)
  • Graph (Background Image)
  • HTML (Insert Asset)
  • Label (Background Image)
  • Match (Choice Name, Bucket Name)
  • Multiple Choice (Choice Text)
  • and any other places we use the asset chooser and

Note: I also removed the one line where we broadcast the scrollToComponent event

Closes #2614

@geoffreykwan geoffreykwan added the 1 point can be completed in 1 hour or less label Sep 15, 2020
@hirokiterashima hirokiterashima merged commit d775478 into develop Sep 16, 2020
@hirokiterashima hirokiterashima deleted the issue-2614-replace-openAssetChooser-and-assetSelected-events branch September 16, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
1 point can be completed in 1 hour or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace openAssetChooser and assetSelected events
2 participants
@geoffreykwan @hirokiterashima