Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace currentNodeChanged and currentStepChanged events with an observable #2618

Closed
geoffreykwan opened this issue Sep 16, 2020 · 0 comments · Fixed by #2619
Closed

Replace currentNodeChanged and currentStepChanged events with an observable #2618

geoffreykwan opened this issue Sep 16, 2020 · 0 comments · Fixed by #2619
Assignees
@geoffreykwan
Labels
2 points can be completed in 2 hours
Milestone
5.16

Comments

@geoffreykwan
Copy link
Member

Description

Replace all the $broadcast('currentNodeChanged') and $on('currentNodeChanged') calls with an observable.

Remove the currentStepChanged event since it is being fired but nothing is listening for it.
@geoffreykwan geoffreykwan added the 2 points can be completed in 2 hours label Sep 16, 2020
@geoffreykwan geoffreykwan added this to the 5.16 milestone Sep 16, 2020
@geoffreykwan geoffreykwan self-assigned this Sep 16, 2020
geoffreykwan added a commit that referenced this issue Sep 16, 2020
@geoffreykwan
Replaced the currentNodeChanged event with an observable. Also remove…
b8a594b 
…d the currentStepChanged event because nothing is listening for it. #2618
@geoffreykwan geoffreykwan mentioned this issue Sep 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffreykwan geoffreykwan

Labels
2 points can be completed in 2 hours
Projects
None yet
Milestone
5.16
1 participant
@geoffreykwan