Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace currentPeriodChanged event with observables #2616

Closed
geoffreykwan opened this issue Sep 16, 2020 · 0 comments · Fixed by #2617
Closed

Replace currentPeriodChanged event with observables #2616

geoffreykwan opened this issue Sep 16, 2020 · 0 comments · Fixed by #2617
Assignees
@geoffreykwan
Labels
2 points can be completed in 2 hours
Milestone
5.16

Comments

@geoffreykwan
Copy link
Member

Description

Replace all the $broadcast('currentPeriodChanged') and $on('currentPeriodChanged') calls with an observable.
@geoffreykwan geoffreykwan added the 2 points can be completed in 2 hours label Sep 16, 2020
@geoffreykwan geoffreykwan added this to the 5.16 milestone Sep 16, 2020
@geoffreykwan geoffreykwan self-assigned this Sep 16, 2020
geoffreykwan added a commit that referenced this issue Sep 16, 2020
@geoffreykwan
Replaced currentPeriodChanged event with an observable. #2616
88cd174
@geoffreykwan geoffreykwan mentioned this issue Sep 16, 2020
Merged
geoffreykwan added a commit that referenced this issue Sep 16, 2020
@geoffreykwan
Added unsubscribe calls to the currentPeriodChanged observable when c…
00b2f68 
…omponents are destroyed. #2616
geoffreykwan added a commit that referenced this issue Sep 16, 2020
@geoffreykwan
Fixed some problems with using this.. #2616
02b0945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffreykwan geoffreykwan

Labels
2 points can be completed in 2 hours
Projects
None yet
Milestone
5.16
Development

Successfully merging a pull request may close this issue.

Replace currentPeriodChanged event with observables WISE-Community/WISE-DEPRECATED
1 participant
@geoffreykwan