-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codesign Example #93
Codesign Example #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit that I'm mostly relying the regression tests here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes all look reasonable to me, at least to the parts of the code that I am familiar with. Trusting you (and the CI testing) on all of the connection changes in glue_code.py...
Purpose
Add floating co-design example in
examples/03_NREL5MW_OC3_spar
:Major Changes:
Minor Changes:
PtfmMass_Init
as a modeling input, to scalePtfmVol0
as a temporary solution to the issue where the spar's heave is very sensitive to platform massPtfmRefzt
in OpenFAST to 0 when floating, otherwise its the tower base heightweis/control/tune_rosco.py
glue_code.py
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
x
in the boxes that apply.