Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codesign Example #93

Merged
merged 158 commits into from
Apr 23, 2021
Merged

Codesign Example #93

merged 158 commits into from
Apr 23, 2021

Conversation

dzalkind
Copy link
Collaborator

@dzalkind dzalkind commented Mar 17, 2021

Purpose

Add floating co-design example in examples/03_NREL5MW_OC3_spar:

Major Changes:

  • Added NLOpt optimization drivers (WISDEM)
  • Update WISDEM subtree
  • Update input yaml for 03_NREL5MW_OC3_spar example

Minor Changes:

  • Add HydroDyn potential flow data for OC3 spar
  • Add PtfmMass_Init as a modeling input, to scale PtfmVol0 as a temporary solution to the issue where the spar's heave is very sensitive to platform mass
  • Set PtfmRefzt in OpenFAST to 0 when floating, otherwise its the tower base height
  • Add unique wind/wave seeds as modeling options, default = False
  • Compute maximum, standard deviation of platform pitch to use as constraint or merit figure
  • Add floating control info to weis/control/tune_rosco.py
  • Separate omega and zeta as design variables for pitch and torque control
  • Add peak shaving percent as design variable
  • Add recorder for openmdao problems
  • Update schema to reflect above changes
  • Fix rotorse naming issue in glue_code.py

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • [ x] I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@dzalkind dzalkind marked this pull request as ready for review April 22, 2021 20:43
Copy link
Collaborator

@ptrbortolotti ptrbortolotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit that I'm mostly relying the regression tests here...

Copy link
Collaborator

@nikhar-abbas nikhar-abbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look reasonable to me, at least to the parts of the code that I am familiar with. Trusting you (and the CI testing) on all of the connection changes in glue_code.py...

@johnjasa johnjasa merged commit b88a8b3 into WISDEM:develop Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants