Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple re #85

Merged
merged 9 commits into from
Feb 17, 2021
Merged

Multiple re #85

merged 9 commits into from
Feb 17, 2021

Conversation

ptrbortolotti
Copy link
Collaborator

Finalize the capability to support polars at multiple Reynolds. Most of the infrastructure was already there, a few links were missing. I had to update WISDEM to the latest dev

Purpose

Ability to run OF with polars at various Re

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

A geometry yaml with polars at multiple Re would be great to keep testing this capability. Otherwise everything should pass, the DAC example included

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

5a5521b34 Merge pull request #235 from WISDEM/multiple_Re
5ab3d2c87 pushed this by mistake
5a90a5e97 support multiple Re in WEIS
c59651258 Merge pull request #234 from WISDEM/b/fix_unsteady
5ab393ba3 switch to Branlard's polar class for unsteady calcs
8b520ed29 avoiding divide by zero in null cases

git-subtree-dir: WISDEM
git-subtree-split: 5a5521b34ee29096ccd516971b92503f46c3d99e
@ptrbortolotti
Copy link
Collaborator Author

mmm something else is failing now...

Copy link
Member

@gbarter gbarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this. Sorry it turned out to be a little more involved.

@johnjasa johnjasa merged commit 1d37d54 into develop Feb 17, 2021
@ptrbortolotti ptrbortolotti deleted the multiple_Re branch February 17, 2021 22:01
dzalkind added a commit to nikhar-abbas/WEIS that referenced this pull request Dec 20, 2021
50f686dd2 Open Loop Control (WISDEM#98)
f57ee4553 Merge pull request WISDEM#97 from nikhar-abbas/b/listcheck
6f16a9da6 update listcheck method for numpy arrays
aa888a1fc FOCAL Updates (WISDEM#64)
de1a7f8e3 another typo!
9650a58e8 fix install typo
08a8c9f67 Merge pull request WISDEM#89 from nikhar-abbas/develop
feb50489a Merge remote-tracking branch 'upstream/main' into develop
a402e1652 bump version number
2821f729e RAAW Controller (WISDEM#84)
277b637a6 Fix Docs and Minimum Rotor/Generator Speed (WISDEM#83)
6f254299b Update CMakeLsits for VS and ifort compilation (WISDEM#85)
52418867f Merge pull request WISDEM#87 from nikhar-abbas/fix_tests
4d5adb1d9 cleanup, use setuptools
b7f2592bc Combine ROSCO and the ROSCO_toolbox (WISDEM#54)

git-subtree-dir: ROSCO
git-subtree-split: 50f686dd2661756c057f98ade0db1ee5b6e9ece3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants