Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatigue #185

Merged
merged 11 commits into from
Aug 16, 2022
Merged

Fatigue #185

merged 11 commits into from
Aug 16, 2022

Conversation

gbarter
Copy link
Member

@gbarter gbarter commented Aug 15, 2022

Purpose

Better support fatigue calculations of steel structures and account for unit differences in subdyn vs elastodyn.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

c92bffe9b Merge pull request #383 from WISDEM/bug_relglob
5c9f4bc16 resetting truth values
818c79756 fix bug that was sending relative member z-coordinates to water load function instead of global z-coordinates

git-subtree-dir: WISDEM
git-subtree-split: c92bffe9b6467535a39547a3cbb2821f13fac2a1
1670f0305 fixing bug inherited from OpenMDAO output
a370981ad equalizing connections for monopile & jacket to fix cost bugs in jacket
b3aa1fa56 Merge pull request #384 from WISDEM/bug_post
464d62a10 incrementing version
3deeb12a2 correcting some variable references after changes

git-subtree-dir: WISDEM
git-subtree-split: 1670f03053cf106709dc8be5fff20e025a365c89
…calling fatigue postprocessing in additional DLCs
31afc3e48 adding fatigue param based on 10.1016/j.proeng.2013.12.061 eqn 5
4f10a5547 Merge pull request #386 from WISDEM/drive_constr
d63cdfb3b fixing tests
355588953 add more constraints about deflection and non-torque rotation angle for generator rotor and stator attachments

git-subtree-dir: WISDEM
git-subtree-split: 31afc3e48724e4b5090070a03908264ea7ba0c9e
@gbarter gbarter requested review from johnjasa and dzalkind and removed request for johnjasa August 15, 2022 16:57
ult_stress=inputs['tower_ultstress'][0],
S_intercept=inputs['tower_wohlerA'][0])
ult_stress=1e-3*inputs['tower_ultstress'][0],
S_intercept=1e-3*inputs['tower_wohlerA'][0])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to do with the ElastoDyn vs. SubDyn kN vs. N?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see the comment now.

@dzalkind
Copy link
Collaborator

It looks like we're covered on the elastodyn vs. subdyn thing because get_tower_loading and get_monopile_loading use the loads that come from elastodyn and subdyn, respectively. Merge whenever you're ready.

@gbarter
Copy link
Member Author

gbarter commented Aug 16, 2022

Yes, we have get_tower and get_monopile loading, but now they also give consistent (and correct) units.

@gbarter gbarter merged commit 3a76615 into develop Aug 16, 2022
@gbarter gbarter deleted the fatigue branch August 16, 2022 20:05
@dzalkind dzalkind mentioned this pull request Oct 3, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants