-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPC and TE Flap optimization #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86f3a9c4 numerical qualifiers for error handling abd83d73 Add IPC_KP to api changes 844b0693 add CMakeFiles to gitignore 2ade0153 add mutichannel plotting with tuples 7e5e2a3d Error checking foro flp or ipc 79e5d540 Addd IPC_KP to DISCON.IN 0111087a Fix comments in ColemanTransformInverse fded9d42 Add cyclic flap conrol dbd81afd Better logic for filtering RootMOOP and fix notch filter slopes bug 5e40ac40 Add IPC and filtered RootMyc to registry 823f5f00 Add proportional control and cleanup IPC 065befa7 Fix performance table paths afca92fc Update surface and DISCON.INs 262d3f6f rename aerodynblade inputs ee00f678 remove interpolation of blade chord and twist git-subtree-dir: ROSCO git-subtree-split: 86f3a9c4c43cc5c65dcc44589ab27e46dc613ab4
02e08f7d add IPC gains to schema for pass-through ability git-subtree-dir: ROSCO git-subtree-split: 02e08f7d0f1411c11436c4b3c9bdcc5a3e512f30
9bc06254 fix variable names git-subtree-dir: ROSCO git-subtree-split: 9bc06254d62da6434dd5cdaa2dd3b52b5baad2b1
9986ecb3 fix ipc gain printing bug git-subtree-dir: ROSCO git-subtree-split: 9986ecb3533c0b98738bb707306eba637ab74fde
03f2b761 fix ipc gain printing bug REVERT: 9986ecb3 fix ipc gain printing bug git-subtree-dir: ROSCO git-subtree-split: 03f2b761c0d56d0e207189d1e7a3e4bee87a7385
fd169fbb Merge remote-tracking branch 'upstream/full_frame' into f/modeshapes 511e5b1a squeeze arrays for plotting c11c3c81 nrefine from modeling options b482c320 Add step_calc as analysis option 221a8c9e use rank_and_file=True for get_xyz_mode_shapes aa70387b remove print statements b6476fea Merge branch 'develop' of https://github.com/WISDEM/WISDEM into f/modeshapes 458b0bee add "rank and file" method option for get_xyz_modeshapes fb611ce0 continuining to add sophistication to the mode filtering 1d89c819 make non-zero base slope on mode shapes an option that is only activated for towers with something underneath- for now only offshore dc8e125f add test directly from mode fitting spreadsheet output 3122d052 fix normalization if sum is less than 1 da4d77f9 match mode fitting spreadsheet by accounting for base slope c3693445 fix bugs in adding too much mass and not starting mode shapes at tower base 8f8273c4 set the root DV for floating member geometry to be the grid set in the yaml file, not the common grid of bulkheads, ballasts, etc 82df86ae default optimizer should be slsqp b006f431 updating variable naming 6c01dacd fix landbosse issues and other deprecations 0492b9a5 fixing deprecated calls 0a26468b changes to make WEIS glue-code easier b229ff14 do full turbine simulation in frame3dd for monopile to get tower mode shapes right 5469c760 Merge pull request #353 from WISDEM/conda_pyoptsparse f5fbac50 pyoptsparse not available for windows. . . dcf67c30 rely on conda version of pyoptsparse f4c6f2b8 Merge branch 'develop' of github.com:WISDEM/WISDEM into develop cd54b880 adding missing __init__ 5d930592 Merge pull request #351 from WISDEM/test_pip 4207dd36 updated for new OpenMDAO convention to name unnamed Problems 1f5285bf suppressing pip on Windows- cannot figure that one out. Also removing pyside2 from setup.py because it always downloads the pypi one and conflicts with conda 7c4686af more pip sophistication for git workflow, remove complexity for user instructions 33d8a797 test out pip in the CI and more robust conda instructions git-subtree-dir: WISDEM git-subtree-split: fd169fbbd5054b6591dd37377e552c040e82c3fe
e7e10e66 Merge remote-tracking branch 'origin/f/ipc' into f/ipc bee2e8e5 improved flap controller filtering 427f2ac5 refactor flap tuning for normalization methods de5ebc1c Update ROSCO Simulink model with IPC example 77dcc15a Revert "Print OL inputs" f6bea78d Print shape ec401f37 Print more stuf 69e87c49 Make example shorter 8623c86e Print OL inputs 4e2dac46 Allow logging level 3 8e2a642b Print OL inputs 58573a71 Disable other examples bf72b14f Revert "Use PriPath and RootName to name dbg files" ad4409db Merge remote-tracking branch 'nja/f/ipc' into f/ipc 285f7b0e Print AvrSWAP 062fcaa5 Use PriPath and RootName to name dbg files 38a13da4 add control packageg a9f43b94 Print when finished with ROSCO 58b4e1b5 Update discons - resolve conflict c8b23371 Merge remote-tracking branch 'upstream/develop' into f/ipc 480c7c4a Disable logging level 3beca3eb Clean up, hone in on debug call 5692ab84 Add more debugging lines 2 a568be6a Add more debugging lines e119569f Debug OL reading 0971f300 Set wind speed, rotor speed IC in example 14 a362dc47 Fix OL_Input reading 41e0dc6e Fix ccrotor inputs (WISDEM#104) b4c75584 Update DISCONs again db919993 Fix Material parameter path 1dc03765 shorten simulation time 5cb3725e Allow IPC to command pitch value below peak shaving saturation limit 07753d8c Add IPC tuning vars 6caf61ed cleanup and streaamline run_examples 1e5398f9 add examples to readme 26bd784e Update cp surfaces and DISCONS 7f3d89a3 Add example 13 for IPC e35f20a1 expand pitch_initial to 30 degrees 7760bcd7 update coord reader/writer c1d7908d Add IEA15MW_OL.yaml 9a75c711 ignore dbg2 files 28099671 Update Polars to point to coord files b6ba2535 make sure IPC_KP is positive git-subtree-dir: ROSCO git-subtree-split: e7e10e6691d00dd64951a6ba8493b66c6ced1098
This reverts commit b997533.
dd3594d8c Update PR template a4f56e013 Generalize update discons git-subtree-dir: ROSCO git-subtree-split: dd3594d8c3c85d4297a3303258462f7ad5ca837a
51629665d ROSCO 2.6.0 (WISDEM#162) 77278f5d1 Flip Ct and Cq table allocation (WISDEM#129) 5d201855f Fixed wrong formatting of list items (WISDEM#122) ad15bcdd6 ROSCO 2.5.0 (WISDEM#115) 9646dbdab Merge pull request WISDEM#90 from NREL/develop REVERT: bd0562cd4 sigma + ipc (WISDEM#125) REVERT: d52019231 Update docs to reflect CI process REVERT: e9c9378e3 Merge remote-tracking branch 'upstream/develop' into develop REVERT: 4126adbfd Bladed readthedocs (WISDEM#117) REVERT: d7d15b044 Update version in API change docs REVERT: 8c312875c Bladed docs (WISDEM#116) REVERT: 5f18bf8c1 Increment version number REVERT: 9b5499d76 ipc (WISDEM#105) REVERT: a857211fa Allow default inputs (WISDEM#110) REVERT: 41e0dc6e2 Fix ccrotor inputs (WISDEM#104) REVERT: aad739652 Merge pull request WISDEM#103 from nikhar-abbas/hf/robust REVERT: 5d5a9ba82 add bld edgewise freq to robust dict_inputs REVERT: 93dceb7ed Break up if statement in open loop pitch (WISDEM#100) REVERT: 6c1e4dbf1 Restart & registry (WISDEM#99) REVERT: 50f686dd2 Open Loop Control (WISDEM#98) REVERT: f57ee4553 Merge pull request WISDEM#97 from nikhar-abbas/b/listcheck REVERT: 6f16a9da6 update listcheck method for numpy arrays REVERT: aa888a1fc FOCAL Updates (WISDEM#64) git-subtree-dir: ROSCO git-subtree-split: 51629665d22f92770f861daeebcebd47ab32abb1
ptrbortolotti
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great!
dzalkind
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily updates ROSCO and the related WEIS parameters to enable optimization of individual pitch controller gains. This also has some cleanup with regard to the TE flap work, and updates to the most recent ROSCO/develop.
This PR also includes #184 with ROSCO 2.6.0.
Purpose
No specific issues - just feature advances and minor cleanup as mentioned.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Standard tests should cover it. There is no specific IPC optimization test, but I'm not sure that it is necessary.
Checklist
Put an
x
in the boxes that apply.Other
Some weird things are going on with the WISDEM subtree here... I think some weird spacing things happened when I worked through merge conflicts. A few other bits and pieces showed up too - @ptrbortolotti, I might need some guidance here.