Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLC Updates #175

Merged
merged 36 commits into from
May 8, 2022
Merged

DLC Updates #175

merged 36 commits into from
May 8, 2022

Conversation

dzalkind
Copy link
Collaborator

@dzalkind dzalkind commented May 2, 2022 •
edited
Loading

Purpose

Added and expanded the capability of some DLCs. More details to follow.

Major Updates:

  • Add DLC 5.1 (shutdown) using OpenFAST control logic
  • Add user-defined yaw misalignments, for DLCs 1.1, 6.1, and 6.3
  • Add varied azimuth starting positions for DLCs 1.4 and 5.1
  • Add unique wave seeds for DLC 1.4
  • Don't use BEM in AeroDyn if parked
  • Add user defined PLExp for any DLC
  • Add a 500-year case (DLC 6.5, mostly custom inputs)
  • Add custom turbulence percent for all DLCs

Minor Updates:

  • Updated OpenFAST: pulled dev into a branch with TMDs and python library on Apr 1 (faa4048)
  • Add an example in 02_control_opt for running loads cases without WISDEM
  • Clean up various examples: 1. IECTurbC is a DLC option, turbulence_class is an environment option. 2. wave_height/period typos
  • Make JDampings a list of floats, like in schema

TODO:

  • Check OpenFAST subtree, something going on there
  • Clean up examples, lots of small changes for testing new features for offshore projects

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

gbarter and others added 30 commits March 1, 2022 17:51
@gbarter
Merge pull request #166 from WISDEM/develop
500ac4c 
Trial PR to prep for the extensive integrations across all branches & OF to come
@gbarter
adding DOI badge
1db6a7e
@dzalkind
Set up loads case
7e9ce71
@dzalkind
Allow yaw misalignment in DLC 1.1, user defined for others as well
cbbafe4
@dzalkind
Disable Hydro, Mooring in OpenFAST
08ec042
@dzalkind
Enable setting of wind class if WISDEM not used
e430098
@dzalkind
Enable custom URef and TI in DLC 6.X
bc98ae1
@dzalkind
Merge remote-tracking branch 'upstream/develop' into shutdown
42b2816
@dzalkind
Enable custom PLExp in DLCs
df15209
@dzalkind
Remove non-conforming IECturbcs from modeling_options
4eda7e5
@dzalkind
Remove unused IECturbc from modeling options
7e63ef0
@dzalkind
Change aero options when parked, seg faulting in WEIS OF, use other exe
352ba5c
@dzalkind
Re-enable ServoDyn in parked cases
040c241
@dzalkind
Squashed 'OpenFAST/' changes from ee28282fe..6cad4c703
faa4048 
6cad4c703 Merge remote-tracking branch 'upstream/dev' into weis_TMD_python
e6bff8b8c [BugFix] ServoDyn StC control signal channels were not getting reset properly.
c2d6e8ad2 Merge pull request #1062 from rafmudaf/docs/community_contribution
8707a5568 Add references to implementation plans
de7710299 Move developer references to shared docs dir
c74ab1e03 Merge branch 'dev' into docs/community_contribution
032fd16f8 Merge pull request #866 from rafmudaf/docs/legacy
4e754cf21 Typo: change FAST to OpenFAST
ea578d68d Remove redundant section for External Platform
46329eaff Merge branch 'dev' into docs/legacy
0551bdfe2 Reference additional documentation for SD and ED
cfadc91a8 Fix superscript bug
17a291008 Move HD legacy links to the main page
a234f64bd Remove HD user guide link
34941113b Update BeamDyn sectional properties description
0c744ff35 Rename OrcaFlex section to OrcaFlex Interface
17a7d16ad Consolidate module sections
9fd4a6590 Add details for community contribution
636674da3 Merge pull request #803 from andrew-platt/f/SrvD_linearization
2df731656 SrvD lin: merge in r-test/dev
4ceddcff2 SrvD lin: update baselines for new StC linearization cases
aeae69fec SrvD lin: add regression test for StC lin
c86925e79 Merge pull request #1048 from ebranlard/f/map-fix
49ec5ead8 SrvD lin: [BugFix] Nacelle dUdy terms start index incorrect
bf20d8cf0 SrvD lin: fix segfault with invalid channel names and linearizing outlist
3ab8e4d98 MAP: small fix based on MAP 1.3
6fde9fc15 Merge remote-tracking branch 'OpenFAST/dev' into f/SrvD_linearization
8ab68a369 Merge pull request #1047 from ebranlard/f/hd-ABC-lin
0b8426dd0 HD: always allocating A,B,C (Closes #1046)
a574cc7c4 Merge pull request #1045 from bjonkman/f/FVW_divideZero
291938efc FVW: check for potential divide-by-zero in induction output calculations
e49437075 Merge pull request #1043 from bjonkman/f/AD_IO
47a1641f8 Merge pull request #1039 from hkross/bug/AD_Driver_NacelleMesh
cb70b58df AD I/O: re-order subroutine to avoid copies between FVW and BEMT outputs
beb054beb Merge remote tracking branch upstream/dev into bug/AD_Driver_NacelleMesh
e7c855b37 Update regression tests
0279390c7 Reg-test python scripts: fix issue where directory returned is empty (#1021)
36244ba66 Merge pull request #1032 from bjonkman/f/UA_Nodal_Outputs
a5295697b Set AeroDyn driver platform motion outputs to be consistent with OpenFAST definitions
e8c0fb9ae Pass nacelle motion mesh between AeroDyn driver and AeroDyn
eb6b4cdf2 Merge remote-tracking branch 'OpenFAST/dev' into f/SrvD_linearization
7011c397f AD: fix line missing from last commit
3456a6455 Merge pull request #1023 from OpenFAST/dev
803b414ae AD: nodal outputs
70129a8e5 Update version numbers to v3.1 (#1024)
a68e5e3c2 Merge remote-tracking branch 'OpenFAST/dev' into f/SrvD_linearization
a5d6262d6 Merge pull request #664 from andrew-platt/f/StrucCtrl_controls
5087a8d6b ExBladedInterface: added documentation on the interface (not complete, but reasonable reference)
64a25b52c Merge pull request #1020 from bjonkman/b/AD_outputs
c33855eaf Merge remote-tracking branch 'OpenFAST/dev' into f/StrucCtrl_controls
d9ad285ad Merge branch 'b/minor_updates' into b/AD_outputs
9e2ccfe08 AD: add missing output channels to OutListParameters.xlsx
8b1b6b06f Merge pull request #1009 from hkross/bug/AD_Driver_NacelleRef
4f5439593 Merge pull request #920 from bjonkman/b/UA_AFI
916dd8ce6 Merge remote-tracking branch 'OpenFAST/dev' into f/StrucCtrl_controls
204429195 docs: update rtd to use sphinxcontrib-bibtex v2.0.0 and later
744e9b85b AD: set variables for alternate projection method
13800f1f1 AD: remove some unused variables
98d6eaeae AD: combine more of `TwrInfl` and `TwrInflArray` routines
a03a1908d AD: make some 'DiskAvgValues` subroutine  arguments optional
4fb1d8411 AD: remove extra input to subroutine `AllBldNdOuts_InitOut`
92bebdc31 Merge remote-tracking branch 'NREL/dev' into b/minor_updates
e96b4d51d Update comments regarding calling NWTC_Init
ef0879130 Update regression tests
0e83048a7 Fix typo in AeroDyn driver input example files
004dd1af7 Update AeroDyn documentation to add Twr2Shft driver input
56fae69d6 Update regression tests
0df26d480 Make AeroDyn driver nacelle mesh position consistent with glue code
fa39ccced Merge remote tracking branch upstream/dev into bug/AD_Driver_NacelleRef
9231e49f9 Update documentation to indicate Python version required to build it.
d0d94fd73 AD15: node outputs for VUnd{xyz}i in global coords
c9f56f8d0 Increase allowed line length in the FileInfoType parsing
d51cd9b60 Merge branch 'f/StrucCtrl_controls' into f/SrvD_linearization
108c62eb6 Merge remote-tracking branch 'OpenFAST/dev' into f/StrucCtrl_controls
7f2282694 StC: typos in docs
10505e382 Fix typo on last commit
abdf33d4e Remove conditional statement for initialization of BEMT variable (#1001)
088284b07 AD: minor code cleanup
3274264eb Reg_tests python scripts: fix issue where directory returned is empty
c92f5fe25 Lin: CalcSteady, forcing linearization at end of simulation (#958)
ddba7a688 Fix HydroDyn summary file nodal data is incorrect when Member is flipped (#998)
acfc5001b Segment treecode (#919)
2a9507f16 Pass nacelle position and orientation out of AD driver
1f53061ec Merge pull request #996 from andrew-platt/b/BD_BldNdOuts
d3b48f918 [BugFix] BeamDyn nodal outputs occasionally segfaulted
0382beb23 AeroAcoustics cleanup
34449ebc2 AD: add error checking on array allocation
459345626 AeroAcoustics: fix passing of field in array of data types
87902a174 Remove unused variable
f6291f02d Merge remote-tracking branch 'OpenFAST/dev' into f/StrucCtrl_controls
151248cd4 AD-Driver-Doc: adding units for amplitude and frequency
6395e86db [BugFix] AD15 nacelle reference position was set to hub position #2
596208b71 Merge pull request #982 from andrew-platt/b/AD15_NacelleRef
5149ae829 Add more detail to error message from ProcessComFile
ecfddbcc7 AD: compute WriteOutputs for linearization
21cfcdc7b Update error messages/comments
29a72ecb5 AD: allow different blade files when more than rotor is used
56ea06766 AD: remove unnecessary /nonstandard inputs to AD_CalcConstrStateResidual
e3ae00ed7 [BugFix] AD15 nacelle reference position was set to hub position
068ae271d Merge remote-tracking branch 'NREL/dev' into b/minor_updates
5e25d5d13 Update GH actions to update packages for ubuntu debug regression test (#971)
0ed108c60 Simplify logic on check for TurbinePos(3) ==0 for offshore turbines
984ed2dfa Aeroacoustics module: update documentation of name of echo file
16103215c remove unused variable in AeroDyn_Registry.txt
d753351eb Fix typos in AD documentation + source code
842ab60f6 Cleanup AeroAcoustics module
6bd654dae AD: update comments in registry files
47a71457f SrvD: add avrSWAP(66) -- start index to the platform motion info (1001)
c862ef33d StC: fix cmakelists.txt -- had a leftover flag from testing
d3f3580fb SrvD: add check on max number of controller channels, and summary info for channels 35-36
5c51e815d StC: fix extension on summary file for SrvD
57253b8c6 StC: minor documentation fix, and remove redundant file
864444543 update comments
7d5c4c1ce StC: update StC_test_OC4Semi regression test results
e5c8b9fd0 Add Oye and Boing-Vertol models to AD summary file + example input file
1bd3ce007 Change FAST_Types and FAST_Farm_Types to -O2 optimization with intel release on linux
e45c57f1a MD causing seg fault with gcc 10.3.0 on linux
43c7af4ac Corrected the description of SkewModFactor in Documentation (#951)
cb11a0611 FVW: fix FVW when no blades are present
f274df0e0 AD: fix yaw index for sine motion in driver
1e1d726b0 Merge remote-tracking branch 'OpenFAST/dev' into f/StrucCtrl_controls
93b976268 SD: fix condition for potential interface joint bug
332a7b424 Add reg-tests because git is forcing me to
b29cc7b84 Merge remote-tracking branch 'NREL/dev' into b/UA_AFI
5b86ec0c3 SrvD lin: Incorrect variable names in scaling after merge
68e54861f Merge branch 'f/StrucCtrl_controls' into f/SrvD_linearization
699b4e54c Merge branch 'f/UA_docs' into b/UA_AFI
065b502e2 Merge branch 'dev' into b/UA_AFI
ad0c22aaa Update UA documentation for default AFI parameters
c5307062c Remove hard-coded version numbers/dates on modules
51a5faeb8 UA/AFI: Fix calculation of default Cd0, alphaUpper, and alphaLower
ebff1b46c Update this_doc.rst (#911)
07cf74d51 Add resources for module documentation
59cfb8f20 Update ServoDyn index file format
0d7bc4f4c Add NWTC Library description documentation
f74d498cf Add HydroDyn docs
1319d844b Fix an indent
a5dc3149d Add TCF HD outputs to HD Appendix
b8db4b40b Add additional BeamDyn docs
67241a324 Add additional AeroDyn docs
955efc7fc Merge branch 'f/StrucCtrl_controls' into f/SrvD_linearization
554edc64e Merge branch 'f/StrucCtrl_controls' into f/SrvD_linearization
d4d96fa2f SrvD lin: fix seg-fault when SrvD linearized without any StC instances
3647a666a FAST_Lin: Remove redundant call
4121a03f1 SrvD lin: Small typos / bugs in FAST_Lin
a470f1300 SrvD lin: Set unused state info to 0
84e977ae9 SrvD lin: fix precision issue with AllOuts (single prec didn't compile)
45ebcbac8 SrvD lin: missed an update to the FAST_Types.f90 file
e54fbb365 Merge branch 'f/StrucCtrl_controls' into f/SrvD_linearization
b8414a10e Merge branch 'f/StrucCtrl_controls' into f/SrvD_linearization
ff81fbaa3 SrvD lin: update Linear_SrvD_InputSolve_dy
bd09fbf61 SrvD lin: update ED_dy SD_dy BD_dy for SrvD%y
12f474e0d SrvD lin: update SD_du and BD_du routines.
fe4649e09 SrvD lin: update Linear_ED_InputSolve_du with dU^{ED}/du^{SrvD}
c51a98769 SrvD lin: add Linear_Srvd_InputSolve_du routine
df42878ae SrvD lin: improve jacobian index tracking for StC instances
024ac9ad3 SrvD lin: add dXdx routines
a533c5730 SrvD lin: tidy up some code formatting
2262e63e0 SrvD lin: add dYdx and associated routines
5f756d0b3 SrvD lin: add dXdu routines
26361d0b1 SrvD lin: simplify the StC bits of dYdu routine
fc6564bc4 SrvD lin: finish dYdu and fix a few bugs in it
76f9ec1ba SrvD StC: shortcut calculations for prescribed forces
e944aee0f SrvD lin: new routine Comput_dY
603ce479a SrvD lin: logic error in setting rotating frame
80012e586 SrvD lin: partial dYdu of blade StCs
8c62aeec7 SrvD: split the Set_xStC_Outs routines for single instance
1c6c04cf6 SrvD lin: rearrange JacobianPInput for simplification and readability
569260db2 SrvD lin: add index tracking for StC sections of linearization arrays
abce306b6 SrvD lin: update some pieces (now compiles and runs, but garbage)
adf4e4796 SrvD: reorder the StC routines
fe7391234 SrvD lin: update SrvD_GetOP routine
14ca26609 SrvD-lin: Revise Init_Jacobian for more inputs/states

git-subtree-dir: OpenFAST
git-subtree-split: 6cad4c703fd4fd7e1a799217f06cacca260d4c49
@dzalkind
Merge commit 'faa404882cb834b7475a901b8bfcae6eddd0c650' into shutdown
da03a3b
@dzalkind
Add DLC 5.1 to WEIS
40a5618
@dzalkind
Update JDampings read/write
10ea03b
@dzalkind
Fix wave height/period 1/50 typos
893d716
@dzalkind
Add different azimuth starting positions to DLC 5.1
2051447
@dzalkind
Set RefHt_Uni if model not from WISDEM (used in DLCs 1.4, 1.5)
69f8fd9
@dzalkind
Add DLC 6.5 (500-year case)
5332ef0
@gbarter
Merge pull request #173 from WISDEM/develop
8f7ea5c 
PR for WEIS v1.0
@dzalkind
Add n_azimuth option for DLC1.4
757186f
@dzalkind
Enable yaw_misalign for DLC 1.3
093c3b2
@dzalkind
Enable custom RefHt in modeling_options, default is hub_height
08fa428
@dzalkind
Make fst_vt['SubDyn']['JDampings'] a list of floats like in schema
ed582d0
@dzalkind
Merge remote-tracking branch 'upstream/master' into shutdown
544f91c
@dzalkind
Remove default yaw_misalign in schema, set in dlc_generator based on DLC
aebbacc
@dzalkind
Revert a example_02 geometry
53db3cd
@dzalkind
Add loads example to CI
e226d43
@dzalkind dzalkind marked this pull request as ready for review May 6, 2022 20:37
ptrbortolotti
ptrbortolotti approved these changes May 8, 2022
View reviewed changes
Copy link
Collaborator

@ptrbortolotti ptrbortolotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you DZ!

@ptrbortolotti ptrbortolotti merged commit ab7a1dd into develop May 8, 2022
@dzalkind dzalkind deleted the shutdown branch June 6, 2022 18:58
@dzalkind dzalkind mentioned this pull request Oct 3, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbarter gbarter gbarter approved these changes

@ptrbortolotti ptrbortolotti ptrbortolotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzalkind @ptrbortolotti @gbarter