Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aeroelasticse #155

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Aeroelasticse #155

merged 3 commits into from
Nov 19, 2021

Conversation

ptrbortolotti
Copy link
Collaborator

Fix a bug in the fast reader and make all paths to openfast files relative

Purpose

Run aeroelasticse as standalone

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@johnjasa
Copy link
Collaborator

I'm not sure if the test failure is meaningful; I just queued up the jobs to run again. Let's see the results if we need to change anything.

@ptrbortolotti
Copy link
Collaborator Author

I'm a little puzzled. I'm creating a new weis env locally to try to reproduce the error and I've rerun GHA on develop. Stay tuned

@ptrbortolotti
Copy link
Collaborator Author

this will likely fix things, but I'm wondering whether anywhere in WEIS the absolute path to the Cp-Ct-Cq tables is needed, and maybe read directly from the DISCON? @dzalkind any tip?

@ptrbortolotti ptrbortolotti merged commit 90d2af0 into develop Nov 19, 2021
@ptrbortolotti ptrbortolotti deleted the aeroelasticse branch November 19, 2021 03:32
@dzalkind
Copy link
Collaborator

I tend to use absolute paths in ROSCO because we don't handle relative ones that well. It's probably something we can address with some string processing or by borrowing subroutines from OpenFAST, but it's just never been at the top of our priority list.

If it's important for your work, we can get it figured out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants