Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEC Kaimal recoded up #109

Merged
merged 7 commits into from
May 26, 2021
Merged

IEC Kaimal recoded up #109

merged 7 commits into from
May 26, 2021

Conversation

ptrbortolotti
Copy link
Collaborator

I recoded the script of aeroelasticse where the turbulent wind IEC Kaimal spectrum is computed, adding a regression test and removing legacy code

Purpose

Support Level 1 activities

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@dzalkind
Copy link
Collaborator

@ptrbortolotti, I updated the example to check our spectra against TurbSim.

@dzalkind
Copy link
Collaborator

Let's keep this open while we figure out the rotor average spectrum.

Copy link
Collaborator

@dzalkind dzalkind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. Thanks @ptrbortolotti and all!

@johnjasa johnjasa merged commit f422601 into develop May 26, 2021
@ptrbortolotti ptrbortolotti deleted the IEAKaimal branch June 1, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants