Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEIS Error handling/restart after failed Case #241

Closed
mlidGWT opened this issue Oct 24, 2023 · 2 comments
Closed

WEIS Error handling/restart after failed Case #241

mlidGWT opened this issue Oct 24, 2023 · 2 comments

Comments

@mlidGWT
Copy link

mlidGWT commented Oct 24, 2023

Description of feature

Hello,

This is more a question about current WEIS capability with the potential to be a feature request if the functionality doesn't already exist.

I was running a DLC (1.4) using the openfast_dir style of example 02, and case 4 out of 40 failed with an error that I don't think is a simple fix/is more endemic to the challenges of the load case. Setting the error aside, I would like to know if there is a way to restart WEIS at the next case in the list (Case 5) and resume until either the end or another case fails. I don't believe restarting the run would fix it, and I would rather skip over the problematic cases for the time being than spend time troubleshooting the error. Is there any way to do this currently?

Potential solution

One possible way to do this would be for the user to modify the case matrix to remove the completed and problematic Cases, and then run some type of command to get WEIS to resume. Alternatively, if WEIS were to generate all wind and .fst files upfront before running OpenFAST, then I could at least run the remaining .fst files from the command line/a script. A third way might be to have an analysis option to "Skip Fatal", ideally saving the failed case's error message to a log file before moving to the next, and thus allowing all Cases in the matrix to at least be attempted once before the run ends.

@dzalkind
Copy link
Collaborator

Hi Meg,

There is an option to allow failed OpenFAST simulations and continue, like the last option you mention. Here is an example:

General:
    openfast_configuration:
        OF_run_fst: RM1
        # OF_run_dir: outputs/CT_Opt/07_Ptfm_Setup
        save_timeseries: True
        save_iterations: True
        use_exe: True
        allow_fails: True
        fail_value: 9999

A comprehensive list of the input options can be found here in the various schema.

Best, Dan

@mlidGWT
Copy link
Author

mlidGWT commented Oct 26, 2023

Hi Dan,

Thanks for that! I have added it to my file. For reference, options in the modeling_schema don't always work for me (I just provided one example here, and I have others. I'm not sure if there are dependencies or conflicts for some of the options that aren't clear, if I'm doing something wrong, or if some of the options listed don't actually work.

Best,
Meg

@mlidGWT mlidGWT closed this as completed Oct 26, 2023
AthulKrishnaSundarrajan pushed a commit to AthulKrishnaSundarrajan/WEIS that referenced this issue Dec 5, 2023
ba005ac9 Clean up DISCON formatting
f0a7c2fc Clean up tune
34a159a8 Add logic for updating discons
f5f81723 Make GenSpdNotch inds optional based on GenSpdNotch_N
81313a4a Update minimal DISCON inputs for test
74f588ca Clean up example 26
6115f529 Read notch filter inds only if N > 0
7e5916fe Update DISCON files, "tune" filters using F_NotchType control param
9d8dbf7c Merge branch 'mhk' into mhk2
f5a8d639 Add start of filtering toolbox in matlab
bbd058d3 Add separate notch filters for Gen speed, tower top
d530b6bb Merge remote-tracking branch 'athul/mhk' into mhk
467febc9 minor updates to the tuning yaml and the discon file
efca5a84 minor change for Hydrodyn.dat
8b882233 Update WAMIT input to be same as openfast/r-test
1dce98e2 Update MHK with constant power
609c16b9 Add VS_ConstPower to simplify VS_ControlModes
0b812e9e Add example to CI testing
1ddefa10 Tidy up MHK example, input
89310f84 Merge remote-tracking branch 'upstream/develop' into mhk
6fc3aa92 Merge branch 'run_fast_updates' into mhk
7ad6e30e Don't change Notch type if already set and floating
acfae844 Line removal in ReadSetParameters
4ffb4235 Change ROSCO version in setup.py
3c048895 Add documentation for new below rated genspeed reference
fca48185 Run run_FAST from weis more easily
c641b54a Rotor Position Control (WISDEM#255)
8e48da13 minox fix in tuning yaml
2ece7bd6  update tuning yaml for RM1
7c7da784 Extend the number of notch filters on the generator speed and tower-top motion, and update OpenFAST input files for RM1 system
bdef6058 MHK updates
2f069dae Floating Feedback Gain Scheduling (WISDEM#241)
c701f677 OpenFAST 3.5.0 (WISDEM#246)
e5b1af53 Yaw Rate Bug Fix (WISDEM#239)
5fd97e25 Increment version number
12f8fdb4 Merge remote-tracking branch 'upstream/main' into develop

git-subtree-dir: ROSCO
git-subtree-split: ba005ac909e85e75c8632032a4ddf4a0f066089a
dzalkind added a commit that referenced this issue Jan 19, 2024
b994e4de6 ROSCO v2.9.0 (#304)
REVERT: 6c2807a9e Merge remote-tracking branch 'upstream/develop' into v2.9.0_prep
REVERT: 7fa1ae25e Don't check ZMQ period if no ZMQ_Mode
REVERT: 4cdef25d4 Merge pull request #300 from NREL/smart_lib_path
REVERT: b1c943ea0 fixes for windows
REVERT: 8c39105a3 hopefully caught everything
REVERT: 2d0525830 switch to cmake-build-extension and logic for finding rosco library path
REVERT: 45aad140c Add more error checking in checkpoint file I/O
REVERT: c5de22f59 Modernize setup and CI (#297)
REVERT: 92e2ac5ab Reorganize Repo (#294)
REVERT: 6a3b194ac Merge pull request #164 from dzalkind/f/exclusion_zone
REVERT: fb5c43de3 Skip upload of artifacts
REVERT: eed259db9 Update toolbox input rst
REVERT: 9d97bc285 Revert IEA yaml
REVERT: 173a91580 Remove extra update_discons
REVERT: 4f7d27376 Separate TD and TRA control modes
REVERT: 77255d15a Rename TRA example, add to CI testing
REVERT: 2decc8166 Add ZMQ_ID to api change
REVERT: 1e455a0e8 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: f93f28162 Add clarification on fastcall
REVERT: 69da72105 Change guidance in api reference
REVERT: ef5aa138c Add signals to IO and Types
REVERT: 3c9e00fb0 Add PC_RefSpd interim signals
REVERT: b2acd3efb Clean up PRC example
REVERT: 2b0f88223 Set up TRA example
REVERT: 05ed0f4df Wind Farm Control Interface (#280)
REVERT: 47dd2d61e Update API docs
REVERT: be4753b5f Revert PC_PitComC to T
REVERT: 7d6b45a03 Try apt-get update
REVERT: a681eb7ef Update toolbox docs
REVERT: 5b38681c1 Clean up inputs further
REVERT: 9d5e21a7e Clean up Twr_ variables and names names
REVERT: f71b8ec04 Rate limit set point, needs clean up
REVERT: c75738eee Modified ZeroMQ interface to include pitch offsets (#261)
REVERT: a610e55eb Better Open Loop Control Error Catching (#273)
REVERT: dd01047c5 Update .readthedocs.yaml remove old python version
REVERT: 8693d4ba4 Update .readthedocs.yaml
REVERT: 328d29e7d Update .readthedocs.yaml with version key
REVERT: c4790340d Update .readthedocs.yaml with another python version
REVERT: 04d3f5284 Update .readthedocs.yaml with new python version
REVERT: 80973fe16 Update .readthedocs.yaml with python 3.9
REVERT: 6f1ccfa33 Update .readthedocs.yaml with other build options
REVERT: f2a624db1 Update .readthedocs.yaml with build.os
REVERT: 0e800947d Update api_change.rst formatting
REVERT: b66cd1170 Add types to scalars (#264)
REVERT: 31b7cc823 Update API docs
REVERT: 9ca681b3c Clean up more old TD_Modes
REVERT: 3c0c800ca Add Twr_Mode error catching and warnings
REVERT: 93b16623f Remove TD_Mode, regen inputs, docs
REVERT: 2c76747fa Increase max file unit (#253)
REVERT: 4ebd1350f Clean up types, make band total width of band
REVERT: b10ec71b2 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 25cf21977 Re-work exclusion zone with simpler implementation
REVERT: 989ce5ba9 Merge pull request #170 from dzalkind/power_ref_tracking
REVERT: e75baa29a Remove pCrunch notebook
REVERT: 3b0bde0fa Update PRC example with PRC_GenSpeeds
REVERT: 32292e588 Bring back saturation of torque reference speed
REVERT: d9a31fb76 Document API changes
REVERT: 38f27def4 Add LPF on WSE for speed selection, use gen speed rather than rotor
REVERT: b817a5ca8 Bring back new VS_ControlMode that merge lost
REVERT: 3092e387b Tidy example documentation, output
REVERT: 24052dc20 Revert run_FAST cases
REVERT: b5eb5c0ad Use updated DISCON writing functions for PRC inputs
REVERT: ea55560f7 Shorten PRC example
REVERT: b27629b3d Rename power ref example
REVERT: 716b2e46d Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: 63bcb0d4b Extend ROSCO for MHK (#257)
REVERT: 31332d923 Update .readthedocs.yaml to remove use of 'system_packages' as it is being depreciated by readthedocs (#258)
REVERT: c641b54a6 Rotor Position Control (#255)
REVERT: 178217bb1 Regenerate registry, inputs
REVERT: d9547ddcd Fix relative Cp filepaths
REVERT: 9de385b3c Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: 273af277d Regen registry, discons
REVERT: fef92431b Fix relative Cp filepaths
REVERT: d4d4cb261 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 2f069daec Floating Feedback Gain Scheduling (#241)
REVERT: c701f6776 OpenFAST 3.5.0 (#246)
REVERT: e5b1af538 Yaw Rate Bug Fix (#239)
REVERT: 5fd97e254 Increment version number
REVERT: 12f8fdb4b Merge remote-tracking branch 'upstream/main' into develop
REVERT: 90357a2cd Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: 23879c815 Remove old TD_Mode references
REVERT: 1c644ecde Update TRA example
REVERT: 0dc1ad0c1 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 79426f799 Increment version number
REVERT: 339ad5391 Tidy example output
REVERT: 585e2c8b1 Open loop platform control (#236)
REVERT: 24bded08f Add note about offset
REVERT: 60b366d0a Revert openfast changes
REVERT: ac14b174d Init PC_RefSpeed if no PRC
REVERT: de15e52d4 Various bug fixes (#233)
REVERT: 766941943 Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: 8a39f3cc7 Update example with ramp, reference
REVERT: 5a7046f70 Active Wake Control (#230)
REVERT: 099532bc7 Finish merge with awc inputs and registry
REVERT: f1037ec6e Merge remote-tracking branch 'origin/awc' into power_ref_tracking
REVERT: 9e5fd58cd Add PRC example
REVERT: e49f3837d Add latest plot_FAST notebook
REVERT: 1e38c90d7 Update IPC example for testing sat modes
REVERT: 52e370867 Finish merge with inputs and registry
REVERT: fe2470475 Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: fbb44c4b2 Add IPC gain to NREL2p8
REVERT: 5afb385bd Parallelize output processing
REVERT: 90c40416b Add optimized NREL2p8 controller input
REVERT: 820aa6630 Merge pull request #2 from kbrown1snl/patch-2
REVERT: 728c61da3 Update 20_active_wake_control.py
REVERT: 17ce1a5c4 Merge remote-tracking branch 'jfred/patch-1' into awc
REVERT: bc3341760 Update api_change.rst
REVERT: 8e4cf8b24 Allow more than 99 local variables in dbg2
REVERT: 7f12c9c92 Clean up comments
REVERT: 9d7e18de4 Tidy file writing
REVERT: 3851a6baf Remove lingering comment
REVERT: e02379d93 Remove AWC references from IPC
REVERT: 50bd08c19 Tidy up IPC, allow AWC and IPC with warning
REVERT: 50f419119 Update error message
REVERT: 1e25c88ae Fixed bug in added AWC input checks.
REVERT: bd4d7d5d9 Added checks for AWC inputs.
REVERT: cae3f1733 Updated AWC input parameters.
REVERT: 2947b4f10 Dylib -> so in Test_Cases
REVERT: e1379de0a Run ROSCO_testing from anywhere
REVERT: de8d228a6 Fix input file writing, force into int in write_array
REVERT: 5e75601ca Make AWC_n a list, too
REVERT: c1e4be785 Force AWC_n into int better
REVERT: 4194da43f Force AWC_n into int
REVERT: e4d7ec259 Tidy input writing, remove `future` references
REVERT: 74c7fcbfe Rename methods in readme
REVERT: 4e2a77833 Remove duplicate PF_Offsets input read
REVERT: ca7c44d8e Tidy print statements, file writing
REVERT: daf77e943 Merge remote-tracking branch 'ndev/rosco_awc_merge' into awc
REVERT: 8ea0a4c97 Merge remote-tracking branch 'jfred/AWC_NREL' into awc
REVERT: 87cde8c52 Merge remote-tracking branch 'upstream/develop' into awc
REVERT: 1ccc1b36b Platform control and Optional Inputs (#227)
REVERT: e8996003c Updated Coleman Transformation based AWC
REVERT: b2fdfbcf9 Update AWC_Mode descriptions
REVERT: b17f35005 Add 2.8 to update_discons, regenerate DISCON Should match closely to original DISCON
REVERT: 4604ebbee Add 20_awc to test_examples
REVERT: a9ec14e98 Update all DISCONs
REVERT: b24f07b6f Merge remote-tracking branch 'upstream/develop' into awc
REVERT: 70d5771c8 Fix file writing in AWC section
REVERT: 687b7603e Undo unintentional changes to wrie_registry.py
REVERT: 3bc2185ce Added NREL-developed AWC-implementation
REVERT: ff0ce39cf Update rosco_types.yaml
REVERT: 797e5544e Update utilities.py
REVERT: 826ca01fb Update toolbox_schema.yaml
REVERT: b141c4e04 Update 20_active_wake_control.py
REVERT: baaa8db06 Update ReadSetParameters.f90
REVERT: 5c878add4 Update ROSCO_Types.f90
REVERT: ae5090b5c Update Controllers.f90
REVERT: 32dc9fd8a Update NREL-2p8-127_DISCON.IN
REVERT: 46e7168d8 Update 20_active_wake_control.py
REVERT: 87b3f09c5 Revert setup directory
REVERT: de3a6fe44 Tidy up DISCON file writing
REVERT: de16ecdda Test all AWC cases in example 20
REVERT: cabbb2adc Merge pull request #1 from kbrown1snl/patch-1
REVERT: 1824f991a Fix units in schema
REVERT: f6d061f87 Update 20_active_wake_control.py
REVERT: a7d33035f Merge remote-tracking branch 'upstream/main' into develop
REVERT: 83022e586 Prep for more modes
REVERT: 3c40565ea Formatting fixes
REVERT: d93d44321 Update AWC example with instructions/theory
REVERT: 2bb01760d Tidy example
REVERT: 1693602fb Add AWC to toolbox schema
REVERT: 1201a6672 Update other DISCONs
REVERT: cc4080d03 Tidy up input additions
REVERT: da46fac31 Set min pitch for AWC
REVERT: 5c5333b12 Remove LocalVar%PC_MinPit = CntrPar%PC_MinPit, breaking setpoint smoother
REVERT: b102b34d2 Update example to point to correct inputs
REVERT: 80bd691ac Add AWC_Mode and move AWC into subroutine
REVERT: d05ef6c7a Merge branch 'develop' into rosco_awc_merge
REVERT: 2f941e38f Merge remote-tracking branch 'upstream/main' into develop
REVERT: a4717839d Add initial AWC example, needs OF3.4
REVERT: f5c3c1e5d Add case generation updates
REVERT: 42525a98a V270 prep (#218)
REVERT: a1cf97bbe Rename examples (#215)
REVERT: 20c9c9d1d Adding NREL 2.8 127 for AWC testing
REVERT: 0c0e466a8 Fixes to readsetparams and awc location
REVERT: 3155b63dd Add script for updating DISCON versions (#214)
REVERT: c51ed30ac Removed duplicate pitch assignment and removed MinPitch mods for AWC
REVERT: e554c1da0 IPC Saturation Fix [RAAW] (#210)
REVERT: be28641f1 Allow PA_Mode 1 (#213)
REVERT: 515da1797 Make AWC_complexangle a LocalVar for logging
REVERT: 974e271c7 Separate contribution to PitCom from mode calculation
REVERT: 0575d7527 Re-organize AWC pitch contribution, before actuator
REVERT: 1e802638f Apply DbKi to COMPLEX
REVERT: 0be88d47e Add AWC parameters to registry, regenerate types
REVERT: f5428de80 Merge remote-tracking branch 'upstream/develop' into rosco_awc_merge
REVERT: 721fbf5d1 Use new numpy
REVERT: 15c0603fb Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 05d7b3b94 Compatibility with Numpy v1.24 (#208)
REVERT: 75a648cdf AWC First Version, collected changes
REVERT: b3a8b1cbf Try compilers in macOS build
REVERT: b5c65bdb5 Add example_19 to CI
REVERT: c8d08c11d Fix default Twr_GainTau
REVERT: b1e122985 Allow Twr_Mode of 3 in tuning yaml
REVERT: 591571e76 Add Twr_GainFactor and Twr_GainTau
REVERT: 6881ac098 Add TRA example
REVERT: f7bae0009 Tidy input writer
REVERT: a3aa81fac Separate collective pitch command from total, use in SS
REVERT: b1f78e088 Add VS_RefSpd and PC_RefSpd to LocalVars
REVERT: f2db21273 Tidy up merge with develop
REVERT: a2741f20a Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 9d27a333b OpenFAST v3.3.0 (#202)
REVERT: 5ad1d4109 Doc fix (#200)
REVERT: 827b2814f Update sim.py (#196)
REVERT: 602332eac Various Bug Fixes (#188)
REVERT: 9384f0307 Added feature to read AeroDyn 14 files also for the case without tower influence. (#177)
REVERT: decd69470 Various Bug Fixes (#167)
REVERT: 2efac8480 Adding pitch actuator fault (#163)
REVERT: 34ca985ef Update discons
REVERT: b933b3bab Add rotor speed tracking, test case
REVERT: 86c8acfb2 Update Windows install instructions
REVERT: 778822b5d Add generator efficiency to power output of simple simulation
REVERT: ae7b26748 Update example 05 units
REVERT: 16bd05c66 Clean up TwrControl_Mode
REVERT: 2da1a16ab Change TD_Mode to Twr_Mode
REVERT: eec3d5f23 Merge branch 'develop' into f/exclusion_zone
REVERT: 772e36f96 update discons
REVERT: df919635b Update registry
REVERT: 9bc45ce27 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 40a4edc9f F/zmq (#145)
REVERT: b45fb4300 External Control Interface (#141)
REVERT: 9ca75e1e2 Robust control updates (#139)
REVERT: 0bf504ee3 Pass through (#136)
REVERT: 75e7fb8dc RAAW Updates (#133)
REVERT: 50a2f90e3 Add OpenFAST channels that Simulink reads (#135)
REVERT: 5cdb0b5fb Pitch Actuator and IPC updates (#123)
REVERT: e035a7d95 Flip Ct and Cq table allocation (#130)
REVERT: bd0562cd4 sigma + ipc (#125)
REVERT: d52019231 Update docs to reflect CI process
REVERT: e9c9378e3 Merge remote-tracking branch 'upstream/develop' into develop
REVERT: 4126adbfd Bladed readthedocs (#117)
REVERT: d7d15b044 Update version in API change docs
REVERT: 8c312875c Bladed docs (#116)
REVERT: 5f18bf8c1 Increment version number
REVERT: 9b5499d76 ipc (#105)
REVERT: a857211fa Allow default inputs (#110)
REVERT: 1be503c03 Fix print var type for WE_CP
REVERT: 2d8a9451b Update DISCONs
REVERT: 7e30c4d64 Add exclusion zone to example
REVERT: eb9b901b8 Add exclusion zone mode to
REVERT: a5eb72c35 fix units for exclusion zone
REVERT: d50e23a00 Add twr frequency exclusion zone
REVERT: 38a13da46 add control packageg
REVERT: a9f43b948 Print when finished with ROSCO
REVERT: 58b4e1b5d Update discons - resolve conflict
REVERT: c8b23371f Merge remote-tracking branch 'upstream/develop' into f/ipc
REVERT: 480c7c4ad Disable logging level
REVERT: 3beca3eb9 Clean up, hone in on debug call
REVERT: 5692ab844 Add more debugging lines 2
REVERT: a568be6a5 Add more debugging lines
REVERT: e119569f4 Debug OL reading
REVERT: 0971f300c Set wind speed, rotor speed IC in example 14
REVERT: a362dc473 Fix OL_Input reading
REVERT: 41e0dc6e2 Fix ccrotor inputs (#104)
REVERT: b4c755844 Update DISCONs again
REVERT: db919993c Fix Material parameter path
REVERT: 1dc03765f shorten simulation time
REVERT: 5cb3725e3 Allow IPC to command pitch value below peak shaving saturation limit
REVERT: 07753d8ca Add IPC tuning vars
REVERT: 6caf61ed4 cleanup and streaamline run_examples
REVERT: 1e5398f9f add examples to readme
REVERT: 26bd784e9 Update cp surfaces and DISCONS
REVERT: 7f3d89a3d Add example 13 for IPC
REVERT: e35f20a13 expand pitch_initial to 30 degrees
REVERT: 7760bcd77 update coord reader/writer
REVERT: c1d7908dc Add IEA15MW_OL.yaml
REVERT: 9a75c7114 ignore dbg2 files
REVERT: 280996714 Update Polars to point to coord files
REVERT: b6ba25358 make sure IPC_KP is positive
REVERT: 03f2b761c fix ipc gain printing bug
REVERT: 9bc06254d fix variable names
REVERT: 02e08f7d0 add IPC gains to schema for pass-through ability
REVERT: 86f3a9c4c numerical qualifiers for error handling
REVERT: abd83d731 Add IPC_KP to api changes
REVERT: 844b0693d add CMakeFiles to gitignore
REVERT: 2ade01535 add mutichannel plotting with tuples
REVERT: 7e5e2a3d7 Error checking foro flp or ipc
REVERT: 79e5d5400 Addd IPC_KP to DISCON.IN
REVERT: 0111087a8 Fix comments in ColemanTransformInverse
REVERT: fded9d422 Add cyclic flap conrol
REVERT: dbd81afda Better logic for filtering RootMOOP and fix notch filter slopes bug
REVERT: 5e40ac40f Add IPC and filtered RootMyc to registry
REVERT: 823f5f00f Add proportional control and cleanup IPC
REVERT: 065befa76 Fix performance table paths
REVERT: afca92fce Update surface and DISCON.INs
REVERT: 262d3f6fe rename aerodynblade inputs
REVERT: ee00f6786 remove interpolation of blade chord and twist
REVERT: aad739652 Merge pull request #103 from nikhar-abbas/hf/robust
REVERT: 5d5a9ba82 add bld edgewise freq to robust dict_inputs
REVERT: 93dceb7ed Break up if statement in open loop pitch (#100)
REVERT: 6c1e4dbf1 Restart & registry (#99)
REVERT: 50f686dd2 Open Loop Control (#98)
REVERT: f57ee4553 Merge pull request #97 from nikhar-abbas/b/listcheck
REVERT: 6f16a9da6 update listcheck method for numpy arrays
REVERT: aa888a1fc FOCAL Updates (#64)

git-subtree-dir: ROSCO
git-subtree-split: b994e4de67c423ff598a4bb354657b62ff61a50d
dzalkind added a commit that referenced this issue Mar 6, 2024
* Cast raft_cases, so it's easier to save as an input yaml

* fix bug with DT_Out, which is a number, nto a str

* Flush and close OF input files, seems to fix kestrel issue

* Remove numpy from lists of dicts

* Give a cross sectional HD member property to OF at each joint location

* Clean up comment around member cross section properties

* Add documentation for constraints that can come from RAFT/OF

* Ensure some level is enable for rotor_overspeed merit figure

* fix coveralls issue in CI

* Make wave_seeds input consistent

* Fix zeta_max typo

* Add some placeholder doc pages

* Add readthedocs config

* Output total system inertia from RAFT

* Add nacelle accel channels

* Remove old ROSCO

* Squashed 'ROSCO/' content from commit 99c9f872d

git-subtree-dir: ROSCO
git-subtree-split: 99c9f872d9590671be6be1a716ac293467b49e53

* Rename ROSCO_Toolbox imports etc.

* Update example discons

* Update to new Tune_Case directory

* Point to new rosco build directory

* Squashed 'ROSCO/' changes from 99c9f872d..7fa1ae25e

7fa1ae25e Don't check ZMQ period if no ZMQ_Mode
45aad140c Add more error checking in checkpoint file I/O
c5de22f59 Modernize setup and CI (#297)
REVERT: 99c9f872d Merge remote-tracking branch 'upstream/v2.9.0' into v2.9.0
REVERT: c29fc8597 Fix checkpoint testing paths
REVERT: 75c3d2988 F_NumNotchFilts is not allowed to have a default value
REVERT: ba0bc45d0 Update rosco dylib dir
REVERT: 207d3f73e Add Ext_Interface flag

git-subtree-dir: ROSCO
git-subtree-split: 7fa1ae25e6b3866c353d5976e7ac68f597bf73af

* Squashed 'ROSCO/' changes from 7fa1ae25e..6c2807a9e

6c2807a9e Merge remote-tracking branch 'upstream/develop' into v2.9.0_prep
4cdef25d4 Merge pull request #300 from NREL/smart_lib_path
b1c943ea0 fixes for windows
8c39105a3 hopefully caught everything
2d0525830 switch to cmake-build-extension and logic for finding rosco library path

git-subtree-dir: ROSCO
git-subtree-split: 6c2807a9ece26b4b94bc0a78bc4ca8388fba60b0

* Create README.md for example 01

* Add cmake-build-extension

* Save timeseries and iteration data by default

* Simplify openfast_configuration
Remove save iterations/timeseries
Send outputs to same place as analysis outputs

* Remove perf_surface modeling options because they make bad ROSCOs

* Rename optimization example

* Update README.md for 02_control_opt

* Update modeling schema doc page

* Rename 02 example folder

* Rename output folders in 02 examples

* Update example names in tests

* Remove 03 hydro data, should not be necessary anymore

* Point to wisdem geometry

* Remove PotFile

* Simplify 03 single run analysis options, standardize output file

* Standardize 04 example output

* Send 04 OF files to regular output

* Standardize 05 example inputs

* Add readme to example 05

* Point to 05 wisdem input

* Add README for 06 example

* Add README for example 07

* Add README for 08 example

* Add README and tidy 06 example inputs some

* Update test list

* Move comments to 06 README for later use

* Add READMEs

* Tidy up 15_ example inputs

* Rename weis driver in 15_

* Tidy up 13_ example inputs

* Fix path in example 03

* Ensure that ballast rho is distributed with l_fill

* Make BEM dir relative to input files, like most other things

* Make analysis options output relative to input, if it's a relative path

* Add rank_and_file for example 15

* Add simple hst file reader

* Pin pyhams 1.2.1

* Squashed 'ROSCO/' changes from 6c2807a9e..b994e4de6

b994e4de6 ROSCO v2.9.0 (#304)
REVERT: 6c2807a9e Merge remote-tracking branch 'upstream/develop' into v2.9.0_prep
REVERT: 7fa1ae25e Don't check ZMQ period if no ZMQ_Mode
REVERT: 4cdef25d4 Merge pull request #300 from NREL/smart_lib_path
REVERT: b1c943ea0 fixes for windows
REVERT: 8c39105a3 hopefully caught everything
REVERT: 2d0525830 switch to cmake-build-extension and logic for finding rosco library path
REVERT: 45aad140c Add more error checking in checkpoint file I/O
REVERT: c5de22f59 Modernize setup and CI (#297)
REVERT: 92e2ac5ab Reorganize Repo (#294)
REVERT: 6a3b194ac Merge pull request #164 from dzalkind/f/exclusion_zone
REVERT: fb5c43de3 Skip upload of artifacts
REVERT: eed259db9 Update toolbox input rst
REVERT: 9d97bc285 Revert IEA yaml
REVERT: 173a91580 Remove extra update_discons
REVERT: 4f7d27376 Separate TD and TRA control modes
REVERT: 77255d15a Rename TRA example, add to CI testing
REVERT: 2decc8166 Add ZMQ_ID to api change
REVERT: 1e455a0e8 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: f93f28162 Add clarification on fastcall
REVERT: 69da72105 Change guidance in api reference
REVERT: ef5aa138c Add signals to IO and Types
REVERT: 3c9e00fb0 Add PC_RefSpd interim signals
REVERT: b2acd3efb Clean up PRC example
REVERT: 2b0f88223 Set up TRA example
REVERT: 05ed0f4df Wind Farm Control Interface (#280)
REVERT: 47dd2d61e Update API docs
REVERT: be4753b5f Revert PC_PitComC to T
REVERT: 7d6b45a03 Try apt-get update
REVERT: a681eb7ef Update toolbox docs
REVERT: 5b38681c1 Clean up inputs further
REVERT: 9d5e21a7e Clean up Twr_ variables and names names
REVERT: f71b8ec04 Rate limit set point, needs clean up
REVERT: c75738eee Modified ZeroMQ interface to include pitch offsets (#261)
REVERT: a610e55eb Better Open Loop Control Error Catching (#273)
REVERT: dd01047c5 Update .readthedocs.yaml remove old python version
REVERT: 8693d4ba4 Update .readthedocs.yaml
REVERT: 328d29e7d Update .readthedocs.yaml with version key
REVERT: c4790340d Update .readthedocs.yaml with another python version
REVERT: 04d3f5284 Update .readthedocs.yaml with new python version
REVERT: 80973fe16 Update .readthedocs.yaml with python 3.9
REVERT: 6f1ccfa33 Update .readthedocs.yaml with other build options
REVERT: f2a624db1 Update .readthedocs.yaml with build.os
REVERT: 0e800947d Update api_change.rst formatting
REVERT: b66cd1170 Add types to scalars (#264)
REVERT: 31b7cc823 Update API docs
REVERT: 9ca681b3c Clean up more old TD_Modes
REVERT: 3c0c800ca Add Twr_Mode error catching and warnings
REVERT: 93b16623f Remove TD_Mode, regen inputs, docs
REVERT: 2c76747fa Increase max file unit (#253)
REVERT: 4ebd1350f Clean up types, make band total width of band
REVERT: b10ec71b2 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 25cf21977 Re-work exclusion zone with simpler implementation
REVERT: 989ce5ba9 Merge pull request #170 from dzalkind/power_ref_tracking
REVERT: e75baa29a Remove pCrunch notebook
REVERT: 3b0bde0fa Update PRC example with PRC_GenSpeeds
REVERT: 32292e588 Bring back saturation of torque reference speed
REVERT: d9a31fb76 Document API changes
REVERT: 38f27def4 Add LPF on WSE for speed selection, use gen speed rather than rotor
REVERT: b817a5ca8 Bring back new VS_ControlMode that merge lost
REVERT: 3092e387b Tidy example documentation, output
REVERT: 24052dc20 Revert run_FAST cases
REVERT: b5eb5c0ad Use updated DISCON writing functions for PRC inputs
REVERT: ea55560f7 Shorten PRC example
REVERT: b27629b3d Rename power ref example
REVERT: 716b2e46d Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: 63bcb0d4b Extend ROSCO for MHK (#257)
REVERT: 31332d923 Update .readthedocs.yaml to remove use of 'system_packages' as it is being depreciated by readthedocs (#258)
REVERT: c641b54a6 Rotor Position Control (#255)
REVERT: 178217bb1 Regenerate registry, inputs
REVERT: d9547ddcd Fix relative Cp filepaths
REVERT: 9de385b3c Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: 273af277d Regen registry, discons
REVERT: fef92431b Fix relative Cp filepaths
REVERT: d4d4cb261 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 2f069daec Floating Feedback Gain Scheduling (#241)
REVERT: c701f6776 OpenFAST 3.5.0 (#246)
REVERT: e5b1af538 Yaw Rate Bug Fix (#239)
REVERT: 5fd97e254 Increment version number
REVERT: 12f8fdb4b Merge remote-tracking branch 'upstream/main' into develop
REVERT: 90357a2cd Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: 23879c815 Remove old TD_Mode references
REVERT: 1c644ecde Update TRA example
REVERT: 0dc1ad0c1 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 79426f799 Increment version number
REVERT: 339ad5391 Tidy example output
REVERT: 585e2c8b1 Open loop platform control (#236)
REVERT: 24bded08f Add note about offset
REVERT: 60b366d0a Revert openfast changes
REVERT: ac14b174d Init PC_RefSpeed if no PRC
REVERT: de15e52d4 Various bug fixes (#233)
REVERT: 766941943 Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: 8a39f3cc7 Update example with ramp, reference
REVERT: 5a7046f70 Active Wake Control (#230)
REVERT: 099532bc7 Finish merge with awc inputs and registry
REVERT: f1037ec6e Merge remote-tracking branch 'origin/awc' into power_ref_tracking
REVERT: 9e5fd58cd Add PRC example
REVERT: e49f3837d Add latest plot_FAST notebook
REVERT: 1e38c90d7 Update IPC example for testing sat modes
REVERT: 52e370867 Finish merge with inputs and registry
REVERT: fe2470475 Merge remote-tracking branch 'upstream/develop' into power_ref_tracking
REVERT: fbb44c4b2 Add IPC gain to NREL2p8
REVERT: 5afb385bd Parallelize output processing
REVERT: 90c40416b Add optimized NREL2p8 controller input
REVERT: 820aa6630 Merge pull request #2 from kbrown1snl/patch-2
REVERT: 728c61da3 Update 20_active_wake_control.py
REVERT: 17ce1a5c4 Merge remote-tracking branch 'jfred/patch-1' into awc
REVERT: bc3341760 Update api_change.rst
REVERT: 8e4cf8b24 Allow more than 99 local variables in dbg2
REVERT: 7f12c9c92 Clean up comments
REVERT: 9d7e18de4 Tidy file writing
REVERT: 3851a6baf Remove lingering comment
REVERT: e02379d93 Remove AWC references from IPC
REVERT: 50bd08c19 Tidy up IPC, allow AWC and IPC with warning
REVERT: 50f419119 Update error message
REVERT: 1e25c88ae Fixed bug in added AWC input checks.
REVERT: bd4d7d5d9 Added checks for AWC inputs.
REVERT: cae3f1733 Updated AWC input parameters.
REVERT: 2947b4f10 Dylib -> so in Test_Cases
REVERT: e1379de0a Run ROSCO_testing from anywhere
REVERT: de8d228a6 Fix input file writing, force into int in write_array
REVERT: 5e75601ca Make AWC_n a list, too
REVERT: c1e4be785 Force AWC_n into int better
REVERT: 4194da43f Force AWC_n into int
REVERT: e4d7ec259 Tidy input writing, remove `future` references
REVERT: 74c7fcbfe Rename methods in readme
REVERT: 4e2a77833 Remove duplicate PF_Offsets input read
REVERT: ca7c44d8e Tidy print statements, file writing
REVERT: daf77e943 Merge remote-tracking branch 'ndev/rosco_awc_merge' into awc
REVERT: 8ea0a4c97 Merge remote-tracking branch 'jfred/AWC_NREL' into awc
REVERT: 87cde8c52 Merge remote-tracking branch 'upstream/develop' into awc
REVERT: 1ccc1b36b Platform control and Optional Inputs (#227)
REVERT: e8996003c Updated Coleman Transformation based AWC
REVERT: b2fdfbcf9 Update AWC_Mode descriptions
REVERT: b17f35005 Add 2.8 to update_discons, regenerate DISCON Should match closely to original DISCON
REVERT: 4604ebbee Add 20_awc to test_examples
REVERT: a9ec14e98 Update all DISCONs
REVERT: b24f07b6f Merge remote-tracking branch 'upstream/develop' into awc
REVERT: 70d5771c8 Fix file writing in AWC section
REVERT: 687b7603e Undo unintentional changes to wrie_registry.py
REVERT: 3bc2185ce Added NREL-developed AWC-implementation
REVERT: ff0ce39cf Update rosco_types.yaml
REVERT: 797e5544e Update utilities.py
REVERT: 826ca01fb Update toolbox_schema.yaml
REVERT: b141c4e04 Update 20_active_wake_control.py
REVERT: baaa8db06 Update ReadSetParameters.f90
REVERT: 5c878add4 Update ROSCO_Types.f90
REVERT: ae5090b5c Update Controllers.f90
REVERT: 32dc9fd8a Update NREL-2p8-127_DISCON.IN
REVERT: 46e7168d8 Update 20_active_wake_control.py
REVERT: 87b3f09c5 Revert setup directory
REVERT: de3a6fe44 Tidy up DISCON file writing
REVERT: de16ecdda Test all AWC cases in example 20
REVERT: cabbb2adc Merge pull request #1 from kbrown1snl/patch-1
REVERT: 1824f991a Fix units in schema
REVERT: f6d061f87 Update 20_active_wake_control.py
REVERT: a7d33035f Merge remote-tracking branch 'upstream/main' into develop
REVERT: 83022e586 Prep for more modes
REVERT: 3c40565ea Formatting fixes
REVERT: d93d44321 Update AWC example with instructions/theory
REVERT: 2bb01760d Tidy example
REVERT: 1693602fb Add AWC to toolbox schema
REVERT: 1201a6672 Update other DISCONs
REVERT: cc4080d03 Tidy up input additions
REVERT: da46fac31 Set min pitch for AWC
REVERT: 5c5333b12 Remove LocalVar%PC_MinPit = CntrPar%PC_MinPit, breaking setpoint smoother
REVERT: b102b34d2 Update example to point to correct inputs
REVERT: 80bd691ac Add AWC_Mode and move AWC into subroutine
REVERT: d05ef6c7a Merge branch 'develop' into rosco_awc_merge
REVERT: 2f941e38f Merge remote-tracking branch 'upstream/main' into develop
REVERT: a4717839d Add initial AWC example, needs OF3.4
REVERT: f5c3c1e5d Add case generation updates
REVERT: 42525a98a V270 prep (#218)
REVERT: a1cf97bbe Rename examples (#215)
REVERT: 20c9c9d1d Adding NREL 2.8 127 for AWC testing
REVERT: 0c0e466a8 Fixes to readsetparams and awc location
REVERT: 3155b63dd Add script for updating DISCON versions (#214)
REVERT: c51ed30ac Removed duplicate pitch assignment and removed MinPitch mods for AWC
REVERT: e554c1da0 IPC Saturation Fix [RAAW] (#210)
REVERT: be28641f1 Allow PA_Mode 1 (#213)
REVERT: 515da1797 Make AWC_complexangle a LocalVar for logging
REVERT: 974e271c7 Separate contribution to PitCom from mode calculation
REVERT: 0575d7527 Re-organize AWC pitch contribution, before actuator
REVERT: 1e802638f Apply DbKi to COMPLEX
REVERT: 0be88d47e Add AWC parameters to registry, regenerate types
REVERT: f5428de80 Merge remote-tracking branch 'upstream/develop' into rosco_awc_merge
REVERT: 721fbf5d1 Use new numpy
REVERT: 15c0603fb Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 05d7b3b94 Compatibility with Numpy v1.24 (#208)
REVERT: 75a648cdf AWC First Version, collected changes
REVERT: b3a8b1cbf Try compilers in macOS build
REVERT: b5c65bdb5 Add example_19 to CI
REVERT: c8d08c11d Fix default Twr_GainTau
REVERT: b1e122985 Allow Twr_Mode of 3 in tuning yaml
REVERT: 591571e76 Add Twr_GainFactor and Twr_GainTau
REVERT: 6881ac098 Add TRA example
REVERT: f7bae0009 Tidy input writer
REVERT: a3aa81fac Separate collective pitch command from total, use in SS
REVERT: b1f78e088 Add VS_RefSpd and PC_RefSpd to LocalVars
REVERT: f2db21273 Tidy up merge with develop
REVERT: a2741f20a Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 9d27a333b OpenFAST v3.3.0 (#202)
REVERT: 5ad1d4109 Doc fix (#200)
REVERT: 827b2814f Update sim.py (#196)
REVERT: 602332eac Various Bug Fixes (#188)
REVERT: 9384f0307 Added feature to read AeroDyn 14 files also for the case without tower influence. (#177)
REVERT: decd69470 Various Bug Fixes (#167)
REVERT: 2efac8480 Adding pitch actuator fault (#163)
REVERT: 34ca985ef Update discons
REVERT: b933b3bab Add rotor speed tracking, test case
REVERT: 86c8acfb2 Update Windows install instructions
REVERT: 778822b5d Add generator efficiency to power output of simple simulation
REVERT: ae7b26748 Update example 05 units
REVERT: 16bd05c66 Clean up TwrControl_Mode
REVERT: 2da1a16ab Change TD_Mode to Twr_Mode
REVERT: eec3d5f23 Merge branch 'develop' into f/exclusion_zone
REVERT: 772e36f96 update discons
REVERT: df919635b Update registry
REVERT: 9bc45ce27 Merge remote-tracking branch 'upstream/develop' into f/exclusion_zone
REVERT: 40a4edc9f F/zmq (#145)
REVERT: b45fb4300 External Control Interface (#141)
REVERT: 9ca75e1e2 Robust control updates (#139)
REVERT: 0bf504ee3 Pass through (#136)
REVERT: 75e7fb8dc RAAW Updates (#133)
REVERT: 50a2f90e3 Add OpenFAST channels that Simulink reads (#135)
REVERT: 5cdb0b5fb Pitch Actuator and IPC updates (#123)
REVERT: e035a7d95 Flip Ct and Cq table allocation (#130)
REVERT: bd0562cd4 sigma + ipc (#125)
REVERT: d52019231 Update docs to reflect CI process
REVERT: e9c9378e3 Merge remote-tracking branch 'upstream/develop' into develop
REVERT: 4126adbfd Bladed readthedocs (#117)
REVERT: d7d15b044 Update version in API change docs
REVERT: 8c312875c Bladed docs (#116)
REVERT: 5f18bf8c1 Increment version number
REVERT: 9b5499d76 ipc (#105)
REVERT: a857211fa Allow default inputs (#110)
REVERT: 1be503c03 Fix print var type for WE_CP
REVERT: 2d8a9451b Update DISCONs
REVERT: 7e30c4d64 Add exclusion zone to example
REVERT: eb9b901b8 Add exclusion zone mode to
REVERT: a5eb72c35 fix units for exclusion zone
REVERT: d50e23a00 Add twr frequency exclusion zone
REVERT: 38a13da46 add control packageg
REVERT: a9f43b948 Print when finished with ROSCO
REVERT: 58b4e1b5d Update discons - resolve conflict
REVERT: c8b23371f Merge remote-tracking branch 'upstream/develop' into f/ipc
REVERT: 480c7c4ad Disable logging level
REVERT: 3beca3eb9 Clean up, hone in on debug call
REVERT: 5692ab844 Add more debugging lines 2
REVERT: a568be6a5 Add more debugging lines
REVERT: e119569f4 Debug OL reading
REVERT: 0971f300c Set wind speed, rotor speed IC in example 14
REVERT: a362dc473 Fix OL_Input reading
REVERT: 41e0dc6e2 Fix ccrotor inputs (#104)
REVERT: b4c755844 Update DISCONs again
REVERT: db919993c Fix Material parameter path
REVERT: 1dc03765f shorten simulation time
REVERT: 5cb3725e3 Allow IPC to command pitch value below peak shaving saturation limit
REVERT: 07753d8ca Add IPC tuning vars
REVERT: 6caf61ed4 cleanup and streaamline run_examples
REVERT: 1e5398f9f add examples to readme
REVERT: 26bd784e9 Update cp surfaces and DISCONS
REVERT: 7f3d89a3d Add example 13 for IPC
REVERT: e35f20a13 expand pitch_initial to 30 degrees
REVERT: 7760bcd77 update coord reader/writer
REVERT: c1d7908dc Add IEA15MW_OL.yaml
REVERT: 9a75c7114 ignore dbg2 files
REVERT: 280996714 Update Polars to point to coord files
REVERT: b6ba25358 make sure IPC_KP is positive
REVERT: 03f2b761c fix ipc gain printing bug
REVERT: 9bc06254d fix variable names
REVERT: 02e08f7d0 add IPC gains to schema for pass-through ability
REVERT: 86f3a9c4c numerical qualifiers for error handling
REVERT: abd83d731 Add IPC_KP to api changes
REVERT: 844b0693d add CMakeFiles to gitignore
REVERT: 2ade01535 add mutichannel plotting with tuples
REVERT: 7e5e2a3d7 Error checking foro flp or ipc
REVERT: 79e5d5400 Addd IPC_KP to DISCON.IN
REVERT: 0111087a8 Fix comments in ColemanTransformInverse
REVERT: fded9d422 Add cyclic flap conrol
REVERT: dbd81afda Better logic for filtering RootMOOP and fix notch filter slopes bug
REVERT: 5e40ac40f Add IPC and filtered RootMyc to registry
REVERT: 823f5f00f Add proportional control and cleanup IPC
REVERT: 065befa76 Fix performance table paths
REVERT: afca92fce Update surface and DISCON.INs
REVERT: 262d3f6fe rename aerodynblade inputs
REVERT: ee00f6786 remove interpolation of blade chord and twist
REVERT: aad739652 Merge pull request #103 from nikhar-abbas/hf/robust
REVERT: 5d5a9ba82 add bld edgewise freq to robust dict_inputs
REVERT: 93dceb7ed Break up if statement in open loop pitch (#100)
REVERT: 6c1e4dbf1 Restart & registry (#99)
REVERT: 50f686dd2 Open Loop Control (#98)
REVERT: f57ee4553 Merge pull request #97 from nikhar-abbas/b/listcheck
REVERT: 6f16a9da6 update listcheck method for numpy arrays
REVERT: aa888a1fc FOCAL Updates (#64)

git-subtree-dir: ROSCO
git-subtree-split: b994e4de67c423ff598a4bb354657b62ff61a50d

* Clean up discons?

* Replace separate input descriptions with combined WEIS rsts

* Point to maintained ROSCO yamls

* Push actual rst file

* reg traj file to exmp 02 and init OF + tau1_const

* Add script to sync with WISDEM inputs

* improved code to handle initial conditions of openfast

* Point to monopile properly in 09

* Point example 10 to right geometry path

* Fix another geometry path

* Update subtree doc to new module development method

* Revise documentation

* fix bug in HD reader

* get rid of try except for reg traj openfast only

* update READMEs and remove bar usc from 08

* forgot the .py file

* push back bar_usc.yaml

* work on AD15 and SD optional inputs

* twr_freq not needed for FB

* write optional OF inputs only if defined

* Add note about ROSCO dll compilation

* Update documentation (#271)

* update docs and add notebooks

* remove R history

---------

Co-authored-by: dzalkind <[email protected]>
Co-authored-by: pibo <[email protected]>
Co-authored-by: dzalkind <[email protected]>
Co-authored-by: Pietro Bortolotti <[email protected]>
Co-authored-by: Athul Krishna Sundarrajan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants