Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: refresh "marketing" pages with new copy and design #438

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

huijing
Copy link
Collaborator

@huijing huijing commented Feb 15, 2024

This PR:

  • refactors CSS to use logical properties instead
  • moves the respec script out of the /src folder into a /scripts folder instead
  • previews the new landing page design on /index-beta_t8apO3 (temporary until design and copy finalised whereby everything in /index-beta_t8apO3.astro will be ported into /index.html

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for webmonetization-preview ready!

Name Link
🔨 Latest commit c8ae3a8
🔍 Latest deploy log https://app.netlify.com/sites/webmonetization-preview/deploys/65ced2a3133cf10008e9d273
😎 Deploy Preview https://deploy-preview-438--webmonetization-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -12,7 +12,7 @@ export default defineConfig({
description:
"Web Monetization allows websites to automatically receive payments from users, facilitated by the user agent and a user's preferred monetization provider.",
customCss: [
'./node_modules/@interledger/docs-design-system/src/styles/green-theme.css',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -17,11 +17,11 @@ RESPEC_SOURCE="$SPEC_PATH/specification-respec.html"
RESPEC_STATIC="$SPEC_PATH/index.html"

# "$PRETTIER_PATH" "$SPEC_PATH/includes" --write
"$TIDY_PATH" -config "$SPEC_PATH/tidyconfig.txt" -m "$RESPEC_SOURCE"
"$TIDY_PATH" -config "$REPO_ROOT/scripts/tidyconfig.txt" -m "$RESPEC_SOURCE"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the respec script out of the /src folder because Astro doesn't actually like these files in there.
Running the script still works when I checked locally, but verification is welcome.

--space-xl: clamp(3rem, calc(3rem + 0vw), 3rem);
--space-2xl: clamp(4rem, calc(4rem + 0vw), 4rem);
--space-3xl: clamp(6rem, calc(6rem + 0vw), 6rem);
--step--2: clamp(0.6944rem, 0.8175rem + -0.1367vi, 0.7901rem);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utopia.fyi updated their clamp calculations, also added the permalink so I don't have to keep resizing the browser to discover what my original options were.

@@ -0,0 +1,50 @@
---
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new design, hence the weird URL so it's not really publicly accessible. Besides, it should be finalised in the near future, I think this is fine to leave in for now.

@@ -209,7 +209,7 @@ const description = t("site.description");

<style>
.section {
border-bottom: 1px solid var(--sl-color-gray-2);
border-block-end: 1px solid var(--sl-color-gray-2);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the changes from here on out are converting the old syntax to logical properties syntax.

@huijing huijing merged commit 34ae6b3 into main Feb 19, 2024
6 checks passed
@huijing huijing deleted the chj/new-landing-page branch February 19, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant