-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: refresh "marketing" pages with new copy and design #438
Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -12,7 +12,7 @@ export default defineConfig({ | |||
description: | |||
"Web Monetization allows websites to automatically receive payments from users, facilitated by the user agent and a user's preferred monetization provider.", | |||
customCss: [ | |||
'./node_modules/@interledger/docs-design-system/src/styles/green-theme.css', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change mentioned in release notes: https://github.com/interledger/docs-design-system/releases/tag/v0.3.0
@@ -17,11 +17,11 @@ RESPEC_SOURCE="$SPEC_PATH/specification-respec.html" | |||
RESPEC_STATIC="$SPEC_PATH/index.html" | |||
|
|||
# "$PRETTIER_PATH" "$SPEC_PATH/includes" --write | |||
"$TIDY_PATH" -config "$SPEC_PATH/tidyconfig.txt" -m "$RESPEC_SOURCE" | |||
"$TIDY_PATH" -config "$REPO_ROOT/scripts/tidyconfig.txt" -m "$RESPEC_SOURCE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the respec script out of the /src folder because Astro doesn't actually like these files in there.
Running the script still works when I checked locally, but verification is welcome.
--space-xl: clamp(3rem, calc(3rem + 0vw), 3rem); | ||
--space-2xl: clamp(4rem, calc(4rem + 0vw), 4rem); | ||
--space-3xl: clamp(6rem, calc(6rem + 0vw), 6rem); | ||
--step--2: clamp(0.6944rem, 0.8175rem + -0.1367vi, 0.7901rem); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Utopia.fyi updated their clamp calculations, also added the permalink so I don't have to keep resizing the browser to discover what my original options were.
@@ -0,0 +1,50 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the new design, hence the weird URL so it's not really publicly accessible. Besides, it should be finalised in the near future, I think this is fine to leave in for now.
@@ -209,7 +209,7 @@ const description = t("site.description"); | |||
|
|||
<style> | |||
.section { | |||
border-bottom: 1px solid var(--sl-color-gray-2); | |||
border-block-end: 1px solid var(--sl-color-gray-2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the changes from here on out are converting the old syntax to logical properties syntax.
This PR: