fix: use proper feature detection in is-supported-example #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change wallet address to match other examples, removing the .js prefix which could be confusing. Remove deprecated methods for detecting support of a feature in a user agent. Remove DOM query in favor of faster temporary element creation.
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sublimator
reviewed
Jan 12, 2024
| const link = | ||
| document.querySelector('link[rel="monetization"]') || | ||
| document.createElement('link') | ||
| if (link.relList.supports('monetization')) { |
There was a problem hiding this comment.
This example always bugged me - 3 lines logged
sublimator
reviewed
Jan 12, 2024
| @@ -117,12 +117,9 @@ <h3> | |||
| Checking if Web Monetization is supported | |||
| </h3> | |||
| <p> | |||
| There are multiple ways to check if Web Monetization is supported. | |||
There was a problem hiding this comment.
iirc ?? this file is generated, so you'll want to edit the base file, and then run the respec.sh command
There was a problem hiding this comment.
nevermind, this /IS/ the source
https://github.com/WICG/webmonetization/blob/main/src/pages/specification/respec.sh#L21
Prettier was changing the examples to its preferences. The specification should be consistent with other W3C standards' style. https://www.w3.org/community/webed/wiki/Web_Education_community_group_style_guide#Code_standards https://www.w3.org/wiki/Coding_style
The previous instructions did not work after the conversion to Astro, as Astro corrupts the includes and breaks the examples.
jeremiahlee
force-pushed
the
is-supported-example
branch
from
81e224a
to
e23b922
Compare
style: disable Prettier in the respec build script docs: update spec local dev instructions to use the build script
sublimator
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change wallet address to match other examples, removing the .js prefix which could be confusing.
Remove deprecated methods for detecting support of a feature in a user agent.
Remove DOM query in favor of faster temporary element creation.
Tangential issues: