Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iframe support for adAuctionHeaders to spec. #912

Closed
wants to merge 2 commits into from

Conversation

orrb1
Copy link
Collaborator

@orrb1 orrb1 commented Nov 16, 2023

This support is provided by a new adAuctionHeaders attribute on the
iframe element that will have the same functional behavior as the
adAuctionHeaders fetch flag, in that it will trigger the user agent to
send the Sec-Ad-Auction-Fetch request header, and to remove
Ad-Auction-Signals and Ad-Auction-Additional-Bid response headers,
providing their values to the Protected Audience auction.

This is a continuation of #883,
which needed to be closed due to an merge conflict on rebase.


Preview | Diff

This support is provided by a new adAuctionHeaders attribute on the
iframe element that will have the same functional behavior as the
adAuctionHeaders fetch flag, in that it will trigger the user agent to
send the Sec-Ad-Auction-Fetch request header, and to remove
`Ad-Auction-Signals` and `Ad-Auction-Additional-Bid` response headers,
providing their values to the Protected Audience auction.
This support is provided by a new `adAuctionHeaders` attribute on the
iframe element that will have the same functional behavior as the
`adAuctionHeaders` fetch flag, in that it will trigger the user agent to
send the `Sec-Ad-Auction-Fetch` request header, and to remove
`Ad-Auction-Signals` and `Ad-Auction-Additional-Bid` response headers,
providing their values to the Protected Audience auction.

This is a continuation of WICG#883,
which needed to be closed due to an merge conflict on rebase.
@orrb1 orrb1 requested a review from caraitto November 16, 2023 20:13
@orrb1 orrb1 added the spec Relates to the spec label Nov 16, 2023
@caraitto
Copy link
Collaborator

FYI -- on Github, merging is preferred to rebasing -- that's probably why you had to close #883.

@orrb1
Copy link
Collaborator Author

orrb1 commented Nov 17, 2023

FYI -- on Github, merging is preferred to rebasing -- that's probably why you had to close #883.

@orrb1 orrb1 closed this Nov 17, 2023
@orrb1
Copy link
Collaborator Author

orrb1 commented Nov 17, 2023

Sorry, I pressed the wrong button, closed this by accident, and then created yet another PR for this change: #918. Sorry for the confusion.

@caraitto
Copy link
Collaborator

Ah, good thing I saw your last comment, I was getting really confused :)

@caraitto
Copy link
Collaborator

GitHub sure is fun :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Relates to the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants