Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: Fix some errors, such as use of [=this=] in parallel. #875

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Spec: Fix some errors, such as use of [=this=] in parallel. #875

merged 6 commits into from
Nov 6, 2023

Conversation

qingxinwu
Copy link
Collaborator

@qingxinwu qingxinwu commented Oct 23, 2023 •
edited by pr-preview bot
Loading

  1. Fix invalid use of [=this=] in steps that run in parallel. Invalid uses of [=this=] from algorithms running in parallel #671, Generate and score bids parallelism errors #668
  2. Change [=queue a task=] to [=queue a global task=].
  3. Change to [[#SectionHeaderId]] to link to sections, to address this comment.

Preview | Diff

@qingxinwu qingxinwu added the spec Relates to the spec label Oct 23, 2023
@qingxinwu qingxinwu changed the title Fix some errors, such as use of [=this=] in parallel. Spec: Fix some errors, such as use of [=this=] in parallel. Oct 23, 2023
@qingxinwu qingxinwu mentioned this pull request Oct 23, 2023
Closed
@domfarolino
Copy link
Collaborator

I noticed this was uploaded from #671 (comment). Let me know if you want me to review it.

@qingxinwu
Copy link
Collaborator Author

qingxinwu commented Oct 24, 2023 •
edited
Loading

I noticed this was uploaded from #671 (comment). Let me know if you want me to review it.

Wanted to focus on the urgent PRs first (i.e., the IG cap one, Update: replied the comments for that PR. strikethrough (will request review once I replied your comments, planned to do so this afternoon)), and to avoid taking you too much time reviewing other PRs at the same time. Once that is done, I'll request review for some other PRs I uploaded. But if you'd like, it's ready for review, and it's relatively small, so feel free to review it now.

@domfarolino
Copy link
Collaborator

Thanks for the input. I'll hold off until the others are finished if that's alright.

@qingxinwu qingxinwu requested a review from domfarolino October 25, 2023 15:21
@qingxinwu
Copy link
Collaborator Author

Thanks for the input. I'll hold off until the others are finished if that's alright.

I think now it's ready to review, since the IG cap PR is finished. Thanks!

domfarolino
domfarolino approved these changes Oct 31, 2023
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@domfarolino domfarolino merged commit 1edc35e into WICG:main Nov 6, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Nov 6, 2023
@qingxinwu @github-actions
Spec: Fix some errors, such as use of [=this=] in parallel. (#875)
95f0a91 
SHA: 1edc35e
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@qingxinwu qingxinwu deleted the comments branch November 6, 2023 15:27
@qingxinwu qingxinwu mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domfarolino domfarolino domfarolino approved these changes

Assignees
No one assigned
Labels
spec Relates to the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingxinwu @domfarolino